Commit 8dcb415
committed
get_template_roi_tree: expand walk relationships to reach all painted leaves
Robbie reported the Adult T1 Leg (VFB_00120000) ROI tree was
missing painted domains on v2-dev. Live diagnostic on pdb revealed
two separate problems:
1. Only 4 of 678 painted-domain `in_register_with` relationships
on VFB_00120000 carry the `ie.index` property — so the existing
`WHERE exists(ie.index)` filter drops 99.5% of legitimate
painted domains for this template. The master painted-domain
volume on the CDN
/data/VFB/i/0012/0000/VFB_00120000/Leg40-poisson_simple_expanded.nrrd
delineates ~256 distinct uint8 stamp labels, suggesting the
volume geometry is intact — it's the pdb bookkeeping that's
incomplete.
2. Even if all 48 distinct painted classes had `ie.index` set, the
current walk
(root)<-[:SUBCLASSOF|part_of|innervates*0..]-(leaf)
only reached 12 of them from the anatomy_root. The missed
leaves connect via has_sensory_dendrite_in (sensory neurons),
fasciculates_with (nerves), attached_to_part_of (muscle cells),
sends_synaptic_output_to_cell (motor neurons). Adding those to
the relationship list takes the reachable node count from 12 to
80 (full 48-leaf coverage plus the structural parents).
This release fixes (2) only — adds the 4 missing relationship
types to the walk. The `WHERE exists(ie.index)` filter stays in
place; (1) is the right scope for an upstream pdb-curation fix
rather than a VFBquery workaround. The list of 45 currently-
unindexed leg painted classes is reported separately at
Claude CoWork/reports/VFB_00120000-missing-painted-domain-index.md
for the curation step.
`overlaps` is deliberately omitted from the new walk — it's a very
broad spatial relationship in FBbt and would pull in classes that
merely co-locate with leg structures without being part of the leg
ontology.
Sanity:
JRC2018U (rich-index brain): 46 indexed painted classes,
walk now reaches 77 reachable nodes (was 12; under-walking
fixed for the brain too).
Adult T1 Leg: 4 indexed painted classes (unchanged until pdb
curation), walk now reaches 7 nodes (was 3; the few leaves
that ARE indexed get their structural parents in the tree
properly).
Patch bump 1.14.5 -> 1.14.6.1 parent 79a04d6 commit 8dcb415
2 files changed
Lines changed: 15 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5028 | 5028 | | |
5029 | 5029 | | |
5030 | 5030 | | |
5031 | | - | |
| 5031 | + | |
| 5032 | + | |
| 5033 | + | |
| 5034 | + | |
| 5035 | + | |
| 5036 | + | |
| 5037 | + | |
| 5038 | + | |
| 5039 | + | |
| 5040 | + | |
| 5041 | + | |
| 5042 | + | |
| 5043 | + | |
| 5044 | + | |
5032 | 5045 | | |
5033 | 5046 | | |
5034 | 5047 | | |
| |||
0 commit comments