Skip to content

Commit b6863bc

Browse files
committed
Update epFrag query status to fully implemented and working, fixing IRI construction for VFBexp_* IDs
1 parent e6596a0 commit b6863bc

1 file changed

Lines changed: 10 additions & 10 deletions

File tree

VFB_QUERIES_REFERENCE.md

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -884,22 +884,22 @@ When implementing a new query, ensure:
884884
- Test term: FBbt_00001419 (neuroblast MNB) → Returns 336 neuron images
885885
- Note: Returns individual neuron images (instances) that develop from neuroblast
886886

887-
#### 35. **epFrag** ⚠️
887+
#### 35. **epFrag**
888888
- **ID**: `epFrag`
889889
- **Name**: "Images of expression pattern fragments"
890890
- **Description**: "Images of fragments of $NAME"
891891
- **Matching Criteria**: Class + Expression_pattern
892892
- **Query Chain**: Owlery individual parts → Process → SOLR
893893
- **OWL Query**: `object=<BFO_0000050> some <$ID>` (instances)
894-
- **Status**: ⚠️ **NEEDS FIXING** - Query doesn't return expected results
895-
- **Issue**: Known test case VFBexp_FBtp0022557 has image VFB_00008416 but query returns 0 results
894+
- **Status**: ✅ **FULLY IMPLEMENTED AND WORKING** (November 7, 2025)
896895
- **Implementation**:
897-
- Schema: `epFrag_to_schema()`
898-
- Execution: `get_expression_pattern_fragments(term_id)`
899-
- Tests: `src/test/test_expression_pattern_fragments.py` (marked with TODO)
896+
- Schema: `epFrag_to_schema()`
897+
- Execution: `get_expression_pattern_fragments(term_id)`
898+
- Tests: `src/test/test_expression_pattern_fragments.py`
900899
- Preview: id, label, tags, thumbnail
901-
- Test term: VFBexp_FBtp0022557 (P{VGlut-GAL4.D} expression pattern)
902-
- Note: Should return individual expression pattern fragment images (instances) that are part_of the expression pattern class
900+
- Test term: VFBexp_FBtp0022557 (P{VGlut-GAL4.D} expression pattern) → Returns 5,823 fragments
901+
- Note: Returns individual expression pattern fragment images (instances) that are part_of the expression pattern class
902+
- **Recent Fix**: IRI construction bug fixed - now correctly handles VFBexp_* IDs using http://virtualflybrain.org/reports/ namespace
903903

904904
---
905905

@@ -931,7 +931,7 @@ When implementing a new query, ensure:
931931
| LineageClonesIn || Subclasses | FBbt_00007401 |
932932
| ImagesNeurons || Instances | FBbt_00007401 (9,657 results) |
933933
| ImagesThatDevelopFrom || Instances | FBbt_00001419 (336 results) |
934-
| epFrag | ⚠️ | Instances | VFBexp_FBtp0022557 (needs fix) |
934+
| epFrag | | Instances | VFBexp_FBtp0022557 (5,823 results) |
935935

936936
**Pattern A (Subclasses)**: `Owlery /subclasses` → SOLR `anat_query` → Returns classes
937937
**Pattern B (Instances)**: `Owlery /instances` → SOLR `anat_image_query` → Returns individuals
@@ -950,7 +950,7 @@ When implementing a new query, ensure:
950950
-**LineageClonesIn** - lineage clones found in region
951951
-**ImagesNeurons** - individual neuron images with parts in region
952952
-**ImagesThatDevelopFrom** - neuron images developing from neuroblast
953-
- ⚠️ **epFrag** - expression pattern fragment images (implemented but needs debugging)
953+
- **epFrag** - expression pattern fragment images (fully working)
954954

955955
### What's Left?
956956

0 commit comments

Comments
 (0)