Commit fa983fe
committed
TransgeneExpressionHere: simplify Expressed_in to single-link
v1.14.3 introduced multi-chip rendering for Expressed_in
(label1----id1; label2----id2; +N more) and switched the
geppetto-vfb queryBuilderConfiguration entry from QueryLinkComponent
to QueryLinkArrayComponent. A walk through the codebase showed:
- No other VFBquery query populates the entityDelimiter "----"
wire slots; Reference's QueryLinkArrayComponent config is
scaffolding only and renders plain text per item today.
- GrossTypeLabelsComponent (the only existing multi-click chip
component) depends on a hardcoded label->id table in utils.js
and isn't reusable for dynamic anatomy classes.
- v2 prod's Expressed_in column always displayed a single value
per row (e.g. "pacemaker neuron"), never a list.
So the multi-chip approach was both an invention of new
infrastructure and a behavioural change vs. v2 prod. Backing out:
- Cypher: collapse anat_pairs from a list with cap-at-5 + "+N more"
overflow to a single representative via
apoc.coll.sort(collect(DISTINCT anat.label + '----' + anat.short_form))[0]
which gives the alphabetically first leaf anatomy class within
the Owlery closure. Deterministic, no special-case length logic.
- Schema headers/preview_columns unchanged (column still exists);
the wire format now matches what QueryLinkComponent expects.
Verified locally on pacemaker neuron (FBbt_00006048):
P{GAL4-per.BS} -> 'pacemaker neuron----FBbt_00006048'
P{GAL4-tim.E} -> 'pacemaker neuron----FBbt_00006048'
P{GSV6}GS10340 -> 'pacemaker neuron----FBbt_00006048'
P{cry-GAL4.E} -> 'pacemaker neuron----FBbt_00006048'
matching v2 prod's single-value display for the same entity.
Companion geppetto-vfb commit reverts the QueryLinkArrayComponent
switch and drops the batch4 multi-chip tests.
Patch bump 1.14.3 -> 1.14.4. The wire format change invalidates
stale @with_solr_cache buckets implicitly via shape mismatch.1 parent bb335f2 commit fa983fe
2 files changed
Lines changed: 12 additions & 15 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5424 | 5424 | | |
5425 | 5425 | | |
5426 | 5426 | | |
5427 | | - | |
5428 | | - | |
5429 | | - | |
5430 | | - | |
5431 | | - | |
5432 | | - | |
5433 | | - | |
5434 | | - | |
| 5427 | + | |
| 5428 | + | |
| 5429 | + | |
| 5430 | + | |
| 5431 | + | |
| 5432 | + | |
| 5433 | + | |
| 5434 | + | |
| 5435 | + | |
5435 | 5436 | | |
5436 | 5437 | | |
5437 | 5438 | | |
| |||
5473 | 5474 | | |
5474 | 5475 | | |
5475 | 5476 | | |
5476 | | - | |
| 5477 | + | |
5477 | 5478 | | |
5478 | 5479 | | |
5479 | 5480 | | |
| |||
5501 | 5502 | | |
5502 | 5503 | | |
5503 | 5504 | | |
5504 | | - | |
5505 | | - | |
5506 | | - | |
5507 | | - | |
5508 | | - | |
| 5505 | + | |
5509 | 5506 | | |
5510 | 5507 | | |
5511 | 5508 | | |
| |||
0 commit comments