Skip to content

Improved class aggregation for upstream/downstream connectivity queries#40

Merged
Clare72 merged 6 commits into
mainfrom
connectivity_queries
May 21, 2026
Merged

Improved class aggregation for upstream/downstream connectivity queries#40
Clare72 merged 6 commits into
mainfrom
connectivity_queries

Conversation

@Clare72

@Clare72 Clare72 commented May 11, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@Clare72 Clare72 requested a review from Robbie1977 May 12, 2026 10:25
@Robbie1977

Copy link
Copy Markdown
Contributor

@Clare72

Clare72 commented May 19, 2026

Copy link
Copy Markdown
Contributor Author

Tests that exist but aren't wired into CI

Five connectivity test files in src/test/:

File What it covers In performance job? In python-test job?
test_neuron_neuron_connectivity.py per-neuron partly (via test_query_performance's test_07) no
test_neuron_region_connectivity.py per-neuron partly (via test_07) no
test_upstream_class_connectivity.py class-level no no
test_downstream_class_connectivity.py class-level no no
test_vfb_connectivity.py query_connectivity (cross-dataset) no no

The other CI workflow (python-test.yml) only runs term_info_queries_test.py.

So the three connectivity test files for the class-level and cross-dataset
queries are effectively orphaned — they'll only get exercised if someone runs
them locally.

Shall I add them all @Robbie1977 ?

@Robbie1977

Copy link
Copy Markdown
Contributor

@Clare72 yes please

@Robbie1977

Copy link
Copy Markdown
Contributor

@Clare72 Can you get Claude to check why the tests failed silently and resolve the errors shown in https://github.com/VirtualFlyBrain/VFBquery/actions/runs/26111178920/attempts/1#summary-76788537996

@Clare72 Clare72 merged commit 2e7d34c into main May 21, 2026
6 checks passed
@Clare72 Clare72 deleted the connectivity_queries branch May 21, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants