Fixing #146: performance regression by VEZY · Pull Request #147 · VirtualPlantLab/PlantSimEngine.jl

Fixing #146

VEZY

committed

Improve performance of `flatten_status` by 15 (7.692 μs -> 492.611 ns) + make it type stable

VEZY

committed

use `flatten_status` in `pre_allocate_outputs` + remove the use of the dep graph entirely (not needed at all)

VEZY

committed

Put back passing the object to `pre_allocate_outputs` in `run!`

VEZY

committed

Rename `update_vector_variables` into `set_variables_at_timestep!` + add `!` because it mutates, and moves the arg that is mutated as first argument + ad doc

VEZY

committed

avoid calling `status` several times, assign to `user_status`

VEZY

committed

Fix error of a single Status for all timesteps (I introduced this in 60d448a8867b2410add00ee779e967e1d19d42e7)

VEZY

committed

Update save_results.jl

VEZY

committed

Formatting

VEZY

committed

Fix error of a single Status for all timesteps (i did something weird with git in my previous commit)

VEZY

committed

Update save_results.jl

VEZY

committed

Implements #29 to fix #148

VEZY

committed

Fix minor bugs: nsteps is not an argument to the ModelList anymore, and verbose to the ModelList method of `dep`

VEZY

committed

Merge pull request #149 from VirtualPlantLab/add-dependency-graph-into-ModelList

VEZY

authored

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixing #146: performance regression#147

Fixing #146: performance regression#147
VEZY merged 14 commits into
mainfrom
fix-regression-benchmark

Commits on Aug 8, 2025

Fixing #146

Improve performance of `flatten_status` by 15 (7.692 μs -> 492.611 ns) + make it type stable

use `flatten_status` in `pre_allocate_outputs` + remove the use of the dep graph entirely (not needed at all)

Put back passing the object to `pre_allocate_outputs` in `run!`

Rename `update_vector_variables` into `set_variables_at_timestep!` + add `!` because it mutates, and moves the arg that is mutated as first argument + ad doc

avoid calling `status` several times, assign to `user_status`

Fix error of a single Status for all timesteps (I introduced this in 60d448a8867b2410add00ee779e967e1d19d42e7)

Update save_results.jl

Formatting

Fix error of a single Status for all timesteps (i did something weird with git in my previous commit)

Update save_results.jl

Implements #29 to fix #148

Fix minor bugs: nsteps is not an argument to the ModelList anymore, and verbose to the ModelList method of `dep`

Merge pull request #149 from VirtualPlantLab/add-dependency-graph-into-ModelList