From 2f182814d564e3f960eb95560516d8ae37b613da Mon Sep 17 00:00:00 2001 From: Samuel-AMAP Date: Wed, 3 Dec 2025 17:02:11 +0100 Subject: [PATCH 1/9] Yup, add 1.9 to the yml --- .github/workflows/Benchmarks.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/Benchmarks.yml b/.github/workflows/Benchmarks.yml index 95c944ead..a134b7426 100644 --- a/.github/workflows/Benchmarks.yml +++ b/.github/workflows/Benchmarks.yml @@ -14,6 +14,7 @@ jobs: fail-fast: false matrix: version: + - "1.9" - "1" os: - ubuntu-latest From 6e1c619afa409f0c77c0ea08ba61885e8596133c Mon Sep 17 00:00:00 2001 From: Samuel-AMAP Date: Wed, 3 Dec 2025 17:12:25 +0100 Subject: [PATCH 2/9] Change yml syntax to conform to airspeedvelocity ymls. The syntax in our other ymls doesn't seem to work. --- .github/workflows/Benchmarks.yml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/Benchmarks.yml b/.github/workflows/Benchmarks.yml index a134b7426..06c1480ce 100644 --- a/.github/workflows/Benchmarks.yml +++ b/.github/workflows/Benchmarks.yml @@ -13,9 +13,7 @@ jobs: strategy: fail-fast: false matrix: - version: - - "1.9" - - "1" + julia-version: ["1", "1.10"] os: - ubuntu-latest arch: @@ -23,5 +21,5 @@ jobs: steps: - uses: MilesCranmer/AirspeedVelocity.jl@action-v1 with: - julia-version: ${{ matrix.version }} + julia-version: ${{ matrix.julia-version }} bench-on: ${{ github.event.pull_request.head.sha }} \ No newline at end of file From 5a4b680b5f176135247f46c38b5e77e7225dbed0 Mon Sep 17 00:00:00 2001 From: Samuel-AMAP Date: Wed, 3 Dec 2025 17:19:42 +0100 Subject: [PATCH 3/9] Fix an error for the job name, and fully conform syntax to the snippet on AirSpeedVelocity's readme --- .github/workflows/Benchmarks.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/Benchmarks.yml b/.github/workflows/Benchmarks.yml index 06c1480ce..748777cb6 100644 --- a/.github/workflows/Benchmarks.yml +++ b/.github/workflows/Benchmarks.yml @@ -7,13 +7,13 @@ permissions: pull-requests: write jobs: bench: - name: Julia ${{ matrix.version }} - ${{ matrix.os }} - ${{ matrix.arch }} - ${{ github.event_name }} + name: Julia ${{ matrix.julia }} - ${{ matrix.os }} - ${{ matrix.arch }} - ${{ github.event_name }} runs-on: ${{ matrix.os }} timeout-minutes: 60 strategy: fail-fast: false matrix: - julia-version: ["1", "1.10"] + julia: ['1', '1.9'] os: - ubuntu-latest arch: @@ -21,5 +21,5 @@ jobs: steps: - uses: MilesCranmer/AirspeedVelocity.jl@action-v1 with: - julia-version: ${{ matrix.julia-version }} + julia-version: ${{ matrix.julia }} bench-on: ${{ github.event.pull_request.head.sha }} \ No newline at end of file From 6d86495f52a4eedd6eec07af6c0e0999699fd799 Mon Sep 17 00:00:00 2001 From: Samuel-AMAP Date: Wed, 3 Dec 2025 17:25:53 +0100 Subject: [PATCH 4/9] Hmm, hardcode to 1.9 as a test. This isn't behaving as expected. --- .github/workflows/Benchmarks.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/Benchmarks.yml b/.github/workflows/Benchmarks.yml index 748777cb6..88d920a14 100644 --- a/.github/workflows/Benchmarks.yml +++ b/.github/workflows/Benchmarks.yml @@ -21,5 +21,5 @@ jobs: steps: - uses: MilesCranmer/AirspeedVelocity.jl@action-v1 with: - julia-version: ${{ matrix.julia }} + julia-version: '1.9' bench-on: ${{ github.event.pull_request.head.sha }} \ No newline at end of file From 5d41eef3fea9318a68d133ef54ebeffa05ceabe0 Mon Sep 17 00:00:00 2001 From: Samuel-AMAP Date: Wed, 3 Dec 2025 17:28:36 +0100 Subject: [PATCH 5/9] Still no dice, tweak syntax --- .github/workflows/Benchmarks.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/Benchmarks.yml b/.github/workflows/Benchmarks.yml index 88d920a14..391e9547f 100644 --- a/.github/workflows/Benchmarks.yml +++ b/.github/workflows/Benchmarks.yml @@ -13,7 +13,7 @@ jobs: strategy: fail-fast: false matrix: - julia: ['1', '1.9'] + julia: "1.9" os: - ubuntu-latest arch: @@ -21,5 +21,5 @@ jobs: steps: - uses: MilesCranmer/AirspeedVelocity.jl@action-v1 with: - julia-version: '1.9' + julia-version: "1.9" bench-on: ${{ github.event.pull_request.head.sha }} \ No newline at end of file From 2d7748f12fdee5509387788852340ab7cc81f952 Mon Sep 17 00:00:00 2001 From: Samuel-AMAP Date: Wed, 3 Dec 2025 17:31:16 +0100 Subject: [PATCH 6/9] Surprisingly, the benchmark action name didn't even change. Try forcing that --- .github/workflows/Benchmarks.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/Benchmarks.yml b/.github/workflows/Benchmarks.yml index 391e9547f..3ea7c2110 100644 --- a/.github/workflows/Benchmarks.yml +++ b/.github/workflows/Benchmarks.yml @@ -13,7 +13,8 @@ jobs: strategy: fail-fast: false matrix: - julia: "1.9" + julia: + - "1.9" os: - ubuntu-latest arch: From 09dc12ccc29e4ca9f8b9b56b9fa9ef51211abd08 Mon Sep 17 00:00:00 2001 From: Samuel-AMAP Date: Wed, 3 Dec 2025 17:32:57 +0100 Subject: [PATCH 7/9] Last attempt at a different syntax --- .github/workflows/Benchmarks.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/Benchmarks.yml b/.github/workflows/Benchmarks.yml index 3ea7c2110..16be41461 100644 --- a/.github/workflows/Benchmarks.yml +++ b/.github/workflows/Benchmarks.yml @@ -22,5 +22,6 @@ jobs: steps: - uses: MilesCranmer/AirspeedVelocity.jl@action-v1 with: - julia-version: "1.9" + julia-version: + - "1.9" bench-on: ${{ github.event.pull_request.head.sha }} \ No newline at end of file From 375f5ae25d5ec485eea4aba2fefe847cd62941ab Mon Sep 17 00:00:00 2001 From: Samuel-AMAP Date: Wed, 3 Dec 2025 17:33:36 +0100 Subject: [PATCH 8/9] Hardcode name --- .github/workflows/Benchmarks.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/Benchmarks.yml b/.github/workflows/Benchmarks.yml index 16be41461..9f51ad556 100644 --- a/.github/workflows/Benchmarks.yml +++ b/.github/workflows/Benchmarks.yml @@ -7,7 +7,7 @@ permissions: pull-requests: write jobs: bench: - name: Julia ${{ matrix.julia }} - ${{ matrix.os }} - ${{ matrix.arch }} - ${{ github.event_name }} + name: Julia 1.9 - ${{ matrix.os }} - ${{ matrix.arch }} - ${{ github.event_name }} runs-on: ${{ matrix.os }} timeout-minutes: 60 strategy: @@ -22,6 +22,5 @@ jobs: steps: - uses: MilesCranmer/AirspeedVelocity.jl@action-v1 with: - julia-version: - - "1.9" + julia-version: "1.9" bench-on: ${{ github.event.pull_request.head.sha }} \ No newline at end of file From 38263460cb199e83e2bfda66cc118f20860870c0 Mon Sep 17 00:00:00 2001 From: Samuel-AMAP Date: Wed, 3 Dec 2025 17:36:04 +0100 Subject: [PATCH 9/9] Revert to previous changes, to force merge this PR, the changes might not be visible until the matrix is updated on the main branch... ? --- .github/workflows/Benchmarks.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/Benchmarks.yml b/.github/workflows/Benchmarks.yml index 9f51ad556..a134b7426 100644 --- a/.github/workflows/Benchmarks.yml +++ b/.github/workflows/Benchmarks.yml @@ -7,14 +7,15 @@ permissions: pull-requests: write jobs: bench: - name: Julia 1.9 - ${{ matrix.os }} - ${{ matrix.arch }} - ${{ github.event_name }} + name: Julia ${{ matrix.version }} - ${{ matrix.os }} - ${{ matrix.arch }} - ${{ github.event_name }} runs-on: ${{ matrix.os }} timeout-minutes: 60 strategy: fail-fast: false matrix: - julia: + version: - "1.9" + - "1" os: - ubuntu-latest arch: @@ -22,5 +23,5 @@ jobs: steps: - uses: MilesCranmer/AirspeedVelocity.jl@action-v1 with: - julia-version: "1.9" + julia-version: ${{ matrix.version }} bench-on: ${{ github.event.pull_request.head.sha }} \ No newline at end of file