ModelMapping validations at construction#178
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add more validations to ModelMapping and remember using fields to avoid recomputing things repeatedly. Check more things and make recommendations to the user. Done by adding
ModelMappingInfoandinfofields onModelMappingwith: validated, is_valid, is_multirate, scales, models_per_scale, processes_per_scale, declared_rates, vars_need_init, model_specs, and recommendations.Also detecting multirate from mapping metadata, and removing the
multirate=truefromrun!(not required by the user anymore). This information leaves inmapping.info.is_multirate.Check that all variables mapped to another scale are computed at this other scale (either by a model, or passed as a Status, or computed by a model at another scale onto this scale).
Check which variables are never computed and needed in the Status (per scale if it is multiscale)
Richer
ModelMappingprinting.Add more information about the difference between
IntegrateandAggregatepolicies.Hard dependencies are ignored when the child and the parent are at the same scale and same inferred/declared rate, i.e. no need to provide an
InputBindingsnor anOutputRoutingeven thought the models have similar outputs.