Skip to content

Commit 5adb86e

Browse files
authored
Add explicit overrides in ScalaCliScalafixModule (#4267)
1 parent 6678f5b commit 5adb86e

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

project/settings/package.mill

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -807,13 +807,13 @@ trait ScalaCliScalafixModule extends ScalafixModule {
807807
if (scalaVersion().startsWith("2.")) super.scalafixConfig()
808808
else Some(BuildCtx.workspaceRoot / ".scalafix3.conf")
809809
}
810-
def scalacPluginMvnDeps: T[Seq[Dep]] = super.scalacPluginMvnDeps() ++ {
810+
override def scalacPluginMvnDeps: T[Seq[Dep]] = super.scalacPluginMvnDeps() ++ {
811811
if (scalaVersion().startsWith("2.")) Seq(Deps.semanticDbScalac)
812812
else Nil
813813
}
814814
// Explicitly setting sourceroot, so that Scala CLI doesn't use a wrong one.
815815
// Using BuildCtx.workspaceRoot is more or less required, for scalafix stuff to work fine.
816-
def scalacOptions: T[Seq[String]] = Task {
816+
override def scalacOptions: T[Seq[String]] = Task {
817817
val sv = scalaVersion()
818818
val isScala2 = sv.startsWith("2.")
819819
val sourceRoot = BuildCtx.workspaceRoot
@@ -845,11 +845,11 @@ trait ScalaCliScalafixModule extends ScalafixModule {
845845
trait ScalaCliCrossSbtModule extends CrossSbtModule with ScalaCliModule
846846

847847
trait ScalaCliModule extends ScalaModule {
848-
def javacOptions: T[Seq[String]] = super.javacOptions() ++ Seq(
848+
override def javacOptions: T[Seq[String]] = super.javacOptions() ++ Seq(
849849
"--release",
850850
"16"
851851
)
852-
def scalacOptions: T[Seq[String]] = Task {
852+
override def scalacOptions: T[Seq[String]] = Task {
853853
val sv = scalaVersion()
854854
val isScala213 = sv.startsWith("2.13.")
855855
val extraOptions =

0 commit comments

Comments
 (0)