Skip to content

Don't save duplicate .scalafmt.conf if unnecessary#4291

Merged
Gedochao merged 1 commit into
VirtusLab:mainfrom
Gedochao:fix/3463
May 27, 2026
Merged

Don't save duplicate .scalafmt.conf if unnecessary#4291
Gedochao merged 1 commit into
VirtusLab:mainfrom
Gedochao:fix/3463

Conversation

@Gedochao
Copy link
Copy Markdown
Contributor

Fixes #3463

With this change, .scala-build/.scalafmt.conf will only be saved if the configuration is not otherwise present in the project root, or if the user has overridden any part of the configuration via a command line option (i.e. by passing --scalafmt-version)

Checklist

  • tested the solution locally and it works
  • ran the code formatter (scala-cli fmt .)
  • ran scalafix (./mill -i __.fix)

How much have your relied on LLM-based tools in this contribution?

extensively, Cursor + Claude

How was the solution tested?

added automated tests

@Gedochao Gedochao marked this pull request as ready for review May 27, 2026 09:22
@Gedochao Gedochao requested review from tgodzik and zielinsky May 27, 2026 09:22
@Gedochao Gedochao merged commit 27f0821 into VirtusLab:main May 27, 2026
104 of 106 checks passed
@Gedochao Gedochao deleted the fix/3463 branch May 27, 2026 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scala CLI always copies .scalafmt.conf to .scala-build

2 participants