perf(scanner): lazily materialize imported modules#630
Open
king-tero wants to merge 1 commit into
Open
Conversation
a4e0237 to
f8b8dc5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an opt-in lazy module mode for scans.
With
ScanOptions::lazy_modules(true), imported modules are no longermaterialized eagerly at scan start. A module is executed only when rule
evaluation actually reads one of its fields or calls one of its functions.
This avoids unnecessary PE, Mach-O, and .NET parsing work for rules that
short-circuit before touching the module, and for files that import a module
but never use it at all.
Motivation
Today, importing a module eagerly executes its parser before condition
evaluation.
For example: