Skip to content

refactor: computeColsWidth api call time #3711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fangsmile merged 3 commits into from
Apr 10, 2025
Merged

refactor: computeColsWidth api call time #3711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8bcd898
refactor: computeColsWidth api call time
fangsmile Apr 8, 2025
247611c
fix: repeat call computeColsWidth adaptive mode result error
fangsmile Apr 9, 2025
5d3f0d7
docs: update changlog of rush
fangsmile Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ...on/changes/@visactor/vtable/refactor-computeColsWidth_api_call_time_2025-04-09-06-31.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "fix: repeat call computeColsWidth adaptive mode result error\n\n",
"type": "none",
"packageName": "@visactor/vtable"
}
],
"packageName": "@visactor/vtable",
"email": "892739385@qq.com"
}
8 changes: 6 additions & 2 deletions packages/vtable/src/scenegraph/group-creater/progress/create-group-for-first-screen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,11 +66,15 @@ export function createGroupForFirstScreen(

if (distCol < table.colCount - table.rightFrozenColCount) {
// compute right frozen row height
computeColsWidth(table, table.colCount - table.rightFrozenColCount, table.colCount - 1);
if (table.colCount - table.rightFrozenColCount <= table.colCount - 1) {
computeColsWidth(table, table.colCount - table.rightFrozenColCount, table.colCount - 1);
}
}
if (distRow < table.rowCount - table.bottomFrozenRowCount) {
// compute bottom frozen row height
computeRowsHeight(table, table.rowCount - table.bottomFrozenRowCount, table.rowCount - 1);
if (table.rowCount - table.bottomFrozenRowCount <= table.rowCount - 1) {
computeRowsHeight(table, table.rowCount - table.bottomFrozenRowCount, table.rowCount - 1);
}
}

// update colHeaderGroup rowHeaderGroup bodyGroup position
Expand Down
8 changes: 6 additions & 2 deletions packages/vtable/src/scenegraph/group-creater/progress/proxy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,9 @@ export class SceneProxy {
createColGroup(onceCount: number) {
// compute rows height
const endCol = Math.min(this.totalCol, this.currentCol + onceCount);
computeColsWidth(this.table, this.currentCol + 1, endCol);
if (this.table.widthMode !== 'adaptive') {
computeColsWidth(this.table, this.currentCol + 1, endCol);
}

this.colEnd = endCol;

Expand Down Expand Up @@ -693,7 +695,9 @@ export class SceneProxy {
// colGroup.needUpdate = false;
// }
// }
computeColsWidth(this.table, this.colUpdatePos, distCol);
if (this.table.widthMode === 'autoWidth') {
computeColsWidth(this.table, this.colUpdatePos, distCol);
}
updateColContent(this.colUpdatePos, distCol, this);
this.colUpdatePos = distCol + 1;
}
Expand Down
Loading