Skip to content

Fix/delete exit edit #4826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fangsmile merged 2 commits into from
Dec 17, 2025
+18 −2
Merged

Fix/delete exit edit #4826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e19c954
fix: delete key down should not complete edit cell
fangsmile Dec 16, 2025
44ceac0
docs: update changlog of rush
fangsmile Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/@visactor/vtable/fix-delete_exit_edit_2025-12-16-10-58.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "fix: delete key down should not complete edit cell\n\n",
"type": "none",
"packageName": "@visactor/vtable"
}
],
"packageName": "@visactor/vtable",
"email": "892739385@qq.com"
}
7 changes: 6 additions & 1 deletion packages/vtable-plugins/src/excel-edit-cell-keyboard.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,12 @@ export class ExcelEditCellKeyboardPlugin implements pluginsDefinition.IVTablePlu
//判断是键盘触发编辑单元格的情况下，那么在编辑状态中切换方向需要选中下一个继续编辑
if (this.table.editorManager.editingEditor && this.table.editorManager.beginTriggerEditCellMode === 'keydown') {
const { col, row } = this.table.editorManager.editCell;
this.table.editorManager.completeEdit();
if (eventKey !== ExcelEditCellKeyboardResponse.BACKSPACE && eventKey !== ExcelEditCellKeyboardResponse.DELETE) {
this.table.editorManager.completeEdit();
} else {
//如果输入了删除或退格键，应正常删除输入框内容
return;
}
this.table.getElement().focus();
if (!event.shiftKey && !event.ctrlKey && !event.metaKey) {
//有这些配合键，则不进行选中下一个单元格的行为 执行vtable内部逻辑
Expand Down
2 changes: 1 addition & 1 deletion packages/vtable-sheet/examples/sheet/sheet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ export function createTable() {
},
{
sheetKey: 'sheet5',
sheetTitle: 'Sheet 5',
sheetTitle: 'Sheet5',
columnCount: 20,
rowCount: 100,
firstRowAsHeader: true,
Expand Down
Loading