Skip to content

fix: optimize grouped updateOption refresh path#5200

Open
fangsmile wants to merge 1 commit into
developfrom
fix/issue-5183-group-update-perf
Open

fix: optimize grouped updateOption refresh path#5200
fangsmile wants to merge 1 commit into
developfrom
fix/issue-5183-group-update-perf

Conversation

@fangsmile

Copy link
Copy Markdown
Contributor

Summary

Fixes

  • preserve sorting behavior by falling back to setRecords when sortState changes or active sorting exists
  • sync addRecordRule during refreshRecords
  • reuse _setRecords row hierarchy decision in refresh fast path so grouped data keeps tree semantics

Benchmark

  • issue-like demo: 1000 x 100, groupBy=[Category, Sub-Category], toggle between two record sets by updateOption
  • before: avg about 250.0ms on first stable run, hot run avg about 197.23ms
  • after: avg about 147.2ms on first stable run, hot run avg about 71.23ms

Tests

  • add grouped updateOption regression tests for dataSource reuse, sorting fallback, addRecordRule sync, and grouped row hierarchy
  • rush test passed during push hooks

Closes #5183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment