fix(preview): prevent raw HTML rendering in generated README preview#89
Open
msn698 wants to merge 1 commit intoVishwaGauravIn:mainfrom
Open
fix(preview): prevent raw HTML rendering in generated README preview#89msn698 wants to merge 1 commit intoVishwaGauravIn:mainfrom
msn698 wants to merge 1 commit intoVishwaGauravIn:mainfrom
Conversation
|
@msn698 is attempting to deploy a commit to the vishwagauravin's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR hardens preview rendering in the Preview component by:
html: false(instead ofhtml: true)rel="noopener noreferrer nofollow"on rendered links opened withtarget="_blank"Why
The preview renders user-generated markdown via
innerHTML. Allowing raw HTML in markdown can expose users to script/style injection in preview context. Disabling raw HTML keeps markdown rendering but blocks direct HTML injection.The link
reladdition prevents reverse-tabnabbing and improves outbound link safety.Scope
Small, isolated security-focused change.