Skip to content

Commit bd02b86

Browse files
committed
Remove AFEventSource DataPipe from SupportedDataMethods for performance reasons
Signed-off-by: Johan Fitié <jfitie@gmail.com>
1 parent 0b8825a commit bd02b86

4 files changed

Lines changed: 5 additions & 120 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# DBM
44
Dynamic Bandwidth Monitor\
55
Leak detection method implemented in a real-time data historian\
6-
Copyright (C) 2014-2024 J.H. Fitié, Vitens N.V.
6+
Copyright (C) 2014-2025 J.H. Fitié, Vitens N.V.
77

88
## Description
99
Water company Vitens has created a demonstration site called the Vitens Innovation Playground (VIP), in which new technologies and methodologies are developed, tested, and demonstrated. The projects conducted in the demonstration site can be categorized into one of four themes: energy optimization, real-time leak detection, online water quality monitoring, and customer interaction. In the real-time leak detection theme, a method for leak detection based on statistical demand forecasting was developed.

src/DBMDataRef/DBMDataRef.vb

Lines changed: 2 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
' Dynamic Bandwidth Monitor
22
' Leak detection method implemented in a real-time data historian
3-
' Copyright (C) 2014-2024 J.H. Fitié, Vitens N.V.
3+
' Copyright (C) 2014-2025 J.H. Fitié, Vitens N.V.
44
'
55
' This file is part of DBM.
66
'
@@ -93,17 +93,6 @@ Namespace Vitens.DynamicBandwidthMonitor
9393
Private Shared _dbm As New DBM(New DBMLoggerAFTrace)
9494

9595

96-
Public Shared Function CreateDataPipe As Object
97-
98-
' This Data Reference is a System of Record, so expose the CreateDataPipe
99-
' method and return a new instance of the event source class derived from
100-
' AFEventSource.
101-
102-
Return New DBMEventSource
103-
104-
End Function
105-
106-
10796
Public Overrides Readonly Property SupportedContexts _
10897
As AFDataReferenceContext
10998

@@ -129,10 +118,7 @@ Namespace Vitens.DynamicBandwidthMonitor
129118
Private Function SupportsFutureData As Boolean
130119

131120
' Returns a boolean indicating if this attribute supports future data,
132-
' f.ex. when it returns a forecast. We should not enable the data pipe for
133-
' these attributes as services like the Analyses Service will not be able
134-
' to use future data because the snapshot timestamp is seen as the last
135-
' available timestamp.
121+
' f.ex. when it returns a forecast.
136122

137123
Return Attribute.Trait Is LimitTarget Or
138124
Attribute.Trait Is Forecast Or
@@ -178,10 +164,6 @@ Namespace Vitens.DynamicBandwidthMonitor
178164
' Support future data if available.
179165
SupportedDataMethods = SupportedDataMethods Or AFDataMethods.Future
180166
End If
181-
If Not SupportsFutureData Or Attribute.Trait Is LimitTarget Then
182-
' Support data pipe for non-future data, as well as for Target.
183-
SupportedDataMethods = SupportedDataMethods Or AFDataMethods.DataPipe
184-
End If
185167
Return SupportedDataMethods
186168
End Get
187169

src/DBMDataRef/DBMEventSource.vb

Lines changed: 0 additions & 97 deletions
This file was deleted.

src/dbm/DBMManifest.vb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
' Dynamic Bandwidth Monitor
22
' Leak detection method implemented in a real-time data historian
3-
' Copyright (C) 2014-2024 J.H. Fitié, Vitens N.V.
3+
' Copyright (C) 2014-2025 J.H. Fitié, Vitens N.V.
44
'
55
' This file is part of DBM.
66
'
@@ -30,6 +30,6 @@
3030
"Leak detection method implemented in a real-time data historian")>
3131

3232
<assembly:System.Reflection.AssemblyCopyright(
33-
"Copyright (C) 2014-2024 J.H. Fitié, Vitens N.V.")>
33+
"Copyright (C) 2014-2025 J.H. Fitié, Vitens N.V.")>
3434

3535
<assembly:System.Reflection.AssemblyCompany("Vitens N.V.")>

0 commit comments

Comments
 (0)