Skip to content

fix: correct PohodaSer autoload path and add package dependency#45

Merged
Vitexus merged 1 commit into
mainfrom
fix/pohodaser-autoload-path
May 18, 2026
Merged

fix: correct PohodaSer autoload path and add package dependency#45
Vitexus merged 1 commit into
mainfrom
fix/pohodaser-autoload-path

Conversation

@Vitexus
Copy link
Copy Markdown
Member

@Vitexus Vitexus commented May 18, 2026

Summary

  • Fixed debian/autoload.php line 9: PohodaSer/autoload.phpPohoda/autoload.php to match the actual install path of php-vitexsoftware-pohodaser (which uses the Pohoda\ namespace)
  • Added php-vitexsoftware-pohodaser to Depends in debian/control to declare the dependency explicitly

Problem

Production server (se-zabbix-proxy) was throwing:

PHP Fatal error: Uncaught Error: Failed opening required '/usr/share/php/PohodaSer/autoload.php'
  in /usr/share/php/mServer/autoload.php on line 9

The mServer autoload template referenced PohodaSer/ but php-vitexsoftware-pohodaser installs its autoload to Pohoda/ (matching its Pohoda\ PHP namespace per Debian PHP packaging conventions).

Test plan

  • Build package and verify /usr/share/php/mServer/autoload.php contains require_once '/usr/share/php/Pohoda/autoload.php'
  • Install on test system with php-vitexsoftware-pohodaser present and confirm no fatal errors
  • Verify pohoda-raiffeisenbank scripts load cleanly

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated Debian package dependencies for the Pohoda connector: added the lightools XML library as a required dependency while removing the direct Composer requirement, simplifying package configuration and reducing external installation requirements
    • Corrected the autoloader configuration path to properly reference the Pohoda library from its system installation location, ensuring correct library loading

Review Change Stack

The autoload template referenced /usr/share/php/PohodaSer/autoload.php
but php-vitexsoftware-pohodaser installs to /usr/share/php/Pohoda/
(matching its Pohoda\ namespace). This caused a fatal require_once
failure on production. Also declares php-vitexsoftware-pohodaser as
an explicit package dependency.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 18, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: dafcc208-a0de-4b4a-b016-f623ed6977e0

📥 Commits

Reviewing files that changed from the base of the PR and between ab630d3 and 7acab13.

📒 Files selected for processing (2)
  • debian/autoload.php
  • debian/control

📝 Walkthrough

Walkthrough

This PR updates Debian packaging configuration for the PHP Pohoda Connector. The PHP autoloader now requires the Pohoda autoloader instead of PohodaSer, and package dependencies are adjusted to include php-lightools-xml while removing the explicit composer dependency.

Changes

Debian Packaging Configuration Updates

Layer / File(s) Summary
PHP autoloader path update
debian/autoload.php
The require statement is updated to load /usr/share/php/Pohoda/autoload.php instead of the previous PohodaSer autoloader.
Package dependency updates
debian/control
The Depends field for php-vitexsoftware-pohoda-connector is updated: php-lightools-xml is added and composer is removed, while retaining ${php:Depends}, ${phpcomposer:Depends}, and ${misc:Depends} substvars.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A rabbit hops through debian files so small,
With autoloaders fixed and deps on call,
Pohoda paths and lightools in sight,
The packaging config shines oh so bright! 🐰✨

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/pohodaser-autoload-path

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Vitexus Vitexus merged commit de08467 into main May 18, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant