Skip to content

Commit d39f50e

Browse files
author
lawwong
committed
Add compatible with lateast uxr management
seems like in some version, uxr loaders name use loader class name instead of butified name
1 parent 87340ea commit d39f50e

File tree

10 files changed

+21
-21
lines changed

10 files changed

+21
-21
lines changed

Assets/HTC.UnityPlugin/ViveInputUtility/Scripts/Editor/VRPlatformSettings/OculusGoSettings.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -506,7 +506,7 @@ public override bool support
506506
if (editorGraphicsJobs) { return false; }
507507
#if UNITY_2019_3_OR_NEWER
508508
if (!VIUSettings.activateOculusVRModule && !VIUSettings.activateUnityXRModule) { return false; }
509-
if (!XRPluginManagementUtils.IsXRLoaderEnabled(OculusVRModule.OCULUS_XR_LOADER_NAME, requirdPlatform)) { return false; }
509+
if (!XRPluginManagementUtils.IsXRLoaderEnabled(OculusVRModule.OCULUS_XR_LOADER_NAME, OculusVRModule.OCULUS_XR_LOADER_CLASS_NAME, requirdPlatform)) { return false; }
510510
#else
511511
if (!VIUSettings.activateOculusVRModule && !VIUSettings.activateUnityNativeVRModule) { return false; }
512512
if (!OculusSDK.enabled) { return false; }

Assets/HTC.UnityPlugin/ViveInputUtility/Scripts/Editor/VRPlatformSettings/OculusSettings.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ public override bool support
144144
if (!canSupport) { return false; }
145145
#if UNITY_2019_3_OR_NEWER
146146
if (!VIUSettings.activateOculusVRModule && !VIUSettings.activateUnityXRModule) { return false; }
147-
if (!XRPluginManagementUtils.IsXRLoaderEnabled(OculusVRModule.OCULUS_XR_LOADER_NAME, requirdPlatform)) { return false; }
147+
if (!XRPluginManagementUtils.IsXRLoaderEnabled(OculusVRModule.OCULUS_XR_LOADER_NAME, OculusVRModule.OCULUS_XR_LOADER_CLASS_NAME, requirdPlatform)) { return false; }
148148
#elif UNITY_5_5_OR_NEWER
149149
if (!VIUSettings.activateOculusVRModule && !VIUSettings.activateUnityNativeVRModule) { return false; }
150150
if (!OculusSDK.enabled) { return false; }

Assets/HTC.UnityPlugin/ViveInputUtility/Scripts/Editor/VRPlatformSettings/OpenVRSettings.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -406,7 +406,7 @@ public override bool support
406406
{
407407
if (!canSupport) { return false; }
408408
#if UNITY_2019_3_OR_NEWER
409-
return (VIUSettings.activateSteamVRModule || VIUSettings.activateUnityXRModule) && XRPluginManagementUtils.IsXRLoaderEnabled(SteamVRModule.OPENVR_XR_LOADER_NAME, requirdPlatform);
409+
return (VIUSettings.activateSteamVRModule || VIUSettings.activateUnityXRModule) && XRPluginManagementUtils.IsXRLoaderEnabled(SteamVRModule.OPENVR_XR_LOADER_NAME, SteamVRModule.OPENVR_XR_LOADER_CLASS_NAME, requirdPlatform);
410410
#elif UNITY_5_5_OR_NEWER
411411
return (VIUSettings.activateSteamVRModule || VIUSettings.activateUnityNativeVRModule) && OpenVRSDK.enabled;
412412
#elif UNITY_5_4_OR_NEWER
@@ -629,7 +629,7 @@ public override void OnPreferenceGUI()
629629
{
630630
bool isPackageInstalled = PackageManagerHelper.IsPackageInList(OPENVR_XR_PACKAGE_NAME) ||
631631
PackageManagerHelper.IsPackageInList(OPENVR_XR_PACKAGE_NAME_OLD);
632-
bool isLoaderEnabled = XRPluginManagementUtils.IsXRLoaderEnabled(SteamVRModule.OPENVR_XR_LOADER_NAME, BuildTargetGroup.Standalone);
632+
bool isLoaderEnabled = XRPluginManagementUtils.IsXRLoaderEnabled(SteamVRModule.OPENVR_XR_LOADER_NAME, SteamVRModule.OPENVR_XR_LOADER_CLASS_NAME, BuildTargetGroup.Standalone);
633633
if (isPackageInstalled && !isLoaderEnabled)
634634
{
635635
XRPluginManagementUtils.SetXRLoaderEnabled(SteamVRModule.OPENVR_XR_LOADER_CLASS_NAME, BuildTargetGroup.Standalone, true);

Assets/HTC.UnityPlugin/ViveInputUtility/Scripts/Editor/VRPlatformSettings/OpenXRAndroidOculusSettings.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ public override bool canSupport
7979
if (PackageManagerHelper.IsPackageInList(WAVE_XR_OPENXR_PACKAGE)) { return false; }
8080
if (PackageManagerHelper.IsPackageInList(OCULUS_XR_PACKAGE_NAME)) { return false; }
8181
if (!PackageManagerHelper.IsPackageInList(OPENXR_PLUGIN_PACKAGE_NAME)) { return false; }
82-
if (!XRPluginManagementUtils.IsXRLoaderEnabled(OPENXR_PLUGIN_LOADER_NAME, requirdPlatform)) { return false; }
82+
if (!XRPluginManagementUtils.IsXRLoaderEnabled(OPENXR_PLUGIN_LOADER_NAME, OPENXR_PLUGIN_LOADER_TYPE, requirdPlatform)) { return false; }
8383
return true;
8484
}
8585
}
@@ -90,7 +90,7 @@ public override bool support
9090
{
9191
if (!canSupport) { return false; }
9292
if (!VIUSettings.activateUnityXRModule) { return false; }
93-
if (!XRPluginManagementUtils.IsXRLoaderEnabled(OPENXR_PLUGIN_LOADER_NAME, requirdPlatform)) { return false; }
93+
if (!XRPluginManagementUtils.IsXRLoaderEnabled(OPENXR_PLUGIN_LOADER_NAME, OPENXR_PLUGIN_LOADER_TYPE, requirdPlatform)) { return false; }
9494
if (IsOpenXRFeatureGroupEnabled(requirdPlatform, WAVE_XR_OPENXR_FEATURE_ID)) { return false; }
9595
if (!IsOpenXRFeatureGroupEnabled(requirdPlatform, OCULUS_QUEST_OPENXR_FEATURE_ID)) { return false; }
9696
return true;
@@ -204,7 +204,7 @@ public override void OnPreferenceGUI()
204204
PackageManagerHelper.AddToPackageList(OPENXR_PLUGIN_PACKAGE_NAME);
205205
}
206206
}
207-
else if (!XRPluginManagementUtils.IsXRLoaderEnabled(OPENXR_PLUGIN_LOADER_NAME, requirdPlatform))
207+
else if (!XRPluginManagementUtils.IsXRLoaderEnabled(OPENXR_PLUGIN_LOADER_NAME, OPENXR_PLUGIN_LOADER_TYPE, requirdPlatform))
208208
{
209209
GUI.enabled = false;
210210
ShowToggle(new GUIContent(s_title), false, GUILayout.Width(toggleWidth));

Assets/HTC.UnityPlugin/ViveInputUtility/Scripts/Editor/VRPlatformSettings/OpenXRAndroidWaveSettings.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ public override bool canSupport
8585
if (PackageManagerHelper.IsPackageInList(OCULUS_XR_PACKAGE_NAME)) { return false; }
8686
if (PackageManagerHelper.IsPackageInList(WAVE_XR_PACKAGE_NAME)) { return false; }
8787
if (!PackageManagerHelper.IsPackageInList(WAVE_XR_OPENXR_PACKAGE)) { return false; }
88-
if (!XRPluginManagementUtils.IsXRLoaderEnabled(OPENXR_PLUGIN_LOADER_NAME, requirdPlatform)) { return false; }
88+
if (!XRPluginManagementUtils.IsXRLoaderEnabled(OPENXR_PLUGIN_LOADER_NAME, OPENXR_PLUGIN_LOADER_TYPE, requirdPlatform)) { return false; }
8989
return true;
9090
}
9191
}
@@ -96,7 +96,7 @@ public override bool support
9696
{
9797
if (!canSupport) { return false; }
9898
if (!VIUSettings.activateUnityXRModule) { return false; }
99-
if (!XRPluginManagementUtils.IsXRLoaderEnabled(OPENXR_PLUGIN_LOADER_NAME, requirdPlatform)) { return false; }
99+
if (!XRPluginManagementUtils.IsXRLoaderEnabled(OPENXR_PLUGIN_LOADER_NAME, OPENXR_PLUGIN_LOADER_TYPE, requirdPlatform)) { return false; }
100100
if (IsOpenXRFeatureGroupEnabled(requirdPlatform, OCULUS_QUEST_OPENXR_FEATURE_ID)) { return false; }
101101
if (!IsOpenXRFeatureGroupEnabled(requirdPlatform, WAVE_XR_OPENXR_FEATURE_ID)) { return false; }
102102
return true;
@@ -204,7 +204,7 @@ public override void OnPreferenceGUI()
204204
PackageManagerHelper.AddToPackageList(WAVE_XR_OPENXR_PACKAGE);
205205
}
206206
}
207-
else if (!XRPluginManagementUtils.IsXRLoaderEnabled(OPENXR_PLUGIN_LOADER_NAME, requirdPlatform))
207+
else if (!XRPluginManagementUtils.IsXRLoaderEnabled(OPENXR_PLUGIN_LOADER_NAME, OPENXR_PLUGIN_LOADER_TYPE, requirdPlatform))
208208
{
209209
GUI.enabled = false;
210210
ShowToggle(new GUIContent(s_title), false, GUILayout.Width(toggleWidth));

Assets/HTC.UnityPlugin/ViveInputUtility/Scripts/Editor/VRPlatformSettings/OpenXRDesktopSettings.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ public override bool support
3131
{
3232
if (!canSupport) { return false; }
3333
if (!VIUSettings.activateUnityXRModule) { return false; }
34-
if (!XRPluginManagementUtils.IsXRLoaderEnabled(OPENXR_PLUGIN_LOADER_NAME, requirdPlatform)) { return false; }
34+
if (!XRPluginManagementUtils.IsXRLoaderEnabled(OPENXR_PLUGIN_LOADER_NAME, OPENXR_PLUGIN_LOADER_TYPE, requirdPlatform)) { return false; }
3535
return true;
3636
}
3737
set
@@ -84,7 +84,7 @@ public override void OnPreferenceGUI()
8484
PackageManagerHelper.AddToPackageList(OPENXR_PLUGIN_PACKAGE_NAME);
8585
}
8686
}
87-
else if (!XRPluginManagementUtils.IsXRLoaderEnabled(OPENXR_PLUGIN_LOADER_NAME, requirdPlatform))
87+
else if (!XRPluginManagementUtils.IsXRLoaderEnabled(OPENXR_PLUGIN_LOADER_NAME, OPENXR_PLUGIN_LOADER_TYPE, requirdPlatform))
8888
{
8989
GUI.enabled = false;
9090
ShowToggle(s_title, false, GUILayout.Width(toggleWidth));

Assets/HTC.UnityPlugin/ViveInputUtility/Scripts/Editor/VRPlatformSettings/UnityXRSettings.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public UnityXRRecommendedSettings()
2727
Add(new VIUVersionCheck.RecommendedSetting<int>
2828
{
2929
settingTitle = "Review OpenXR Project Validation Issues",
30-
skipCheckFunc = () => !VIUSettingsEditor.PackageManagerHelper.IsPackageInList(VIUSettingsEditor.OPENXR_PLUGIN_PACKAGE_NAME) || !XRPluginManagementUtils.IsXRLoaderEnabled(UnityXRModule.OPENXR_LOADER_NAME, VIUSettingsEditor.activeBuildTargetGroup),
30+
skipCheckFunc = () => !VIUSettingsEditor.PackageManagerHelper.IsPackageInList(VIUSettingsEditor.OPENXR_PLUGIN_PACKAGE_NAME) || !XRPluginManagementUtils.IsXRLoaderEnabled(UnityXRModule.OPENXR_LOADER_NAME, UnityXRModule.OPENXR_LOADER_CLASS_NAME, VIUSettingsEditor.activeBuildTargetGroup),
3131
currentValueFunc = () => {
3232
OpenXRProjectValidation.GetCurrentValidationIssues(s_tempOpenXRValidationIssues, VIUSettingsEditor.activeBuildTargetGroup);
3333
return s_tempOpenXRValidationIssues.Count;
@@ -60,7 +60,7 @@ public UnityXRRecommendedSettings()
6060
Add(new VIUVersionCheck.RecommendedSetting<bool>
6161
{
6262
settingTitle = "Enable All Feature Sets",
63-
skipCheckFunc = () => !VIUSettingsEditor.PackageManagerHelper.IsPackageInList(VIUSettingsEditor.OPENXR_PLUGIN_PACKAGE_NAME) || !XRPluginManagementUtils.IsXRLoaderEnabled(UnityXRModule.OPENXR_LOADER_NAME, VIUSettingsEditor.activeBuildTargetGroup),
63+
skipCheckFunc = () => !VIUSettingsEditor.PackageManagerHelper.IsPackageInList(VIUSettingsEditor.OPENXR_PLUGIN_PACKAGE_NAME) || !XRPluginManagementUtils.IsXRLoaderEnabled(UnityXRModule.OPENXR_LOADER_NAME, UnityXRModule.OPENXR_LOADER_CLASS_NAME, VIUSettingsEditor.activeBuildTargetGroup),
6464
currentValueFunc = () =>
6565
{
6666
return OpenXRSettings.ActiveBuildTargetInstance.GetFeatures<OpenXRInteractionFeature>().All(feature => feature.enabled);

Assets/HTC.UnityPlugin/ViveInputUtility/Scripts/Editor/VRPlatformSettings/WaveVRSettings.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ public override bool support
127127
if (!VIUSettings.activateWaveVRModule) { return false; }
128128

129129
#if VIU_XR_GENERAL_SETTINGS
130-
if (!(MockHMDSDK.enabled || XRPluginManagementUtils.IsXRLoaderEnabled(UnityXRModule.WAVE_XR_LOADER_NAME, requirdPlatform)))
130+
if (!(MockHMDSDK.enabled || XRPluginManagementUtils.IsXRLoaderEnabled(UnityXRModule.WAVE_XR_LOADER_NAME, UnityXRModule.WAVE_XR_LOADER_CLASS_NAME, requirdPlatform)))
131131
{
132132
return false;
133133
}
@@ -453,7 +453,7 @@ public override void OnPreferenceGUI()
453453
if (VIUProjectSettings.Instance.isInstallingWaveXRPlugin)
454454
{
455455
bool isPackageInstalled = PackageManagerHelper.IsPackageInList(WAVE_XR_PACKAGE_NAME);
456-
bool isLoaderEnabled = XRPluginManagementUtils.IsXRLoaderEnabled(UnityXRModule.WAVE_XR_LOADER_NAME, BuildTargetGroup.Android);
456+
bool isLoaderEnabled = XRPluginManagementUtils.IsXRLoaderEnabled(UnityXRModule.WAVE_XR_LOADER_NAME, UnityXRModule.WAVE_XR_LOADER_CLASS_NAME, BuildTargetGroup.Android);
457457
if (isPackageInstalled && !isLoaderEnabled)
458458
{
459459
XRPluginManagementUtils.SetXRLoaderEnabled(UnityXRModule.WAVE_XR_LOADER_CLASS_NAME, BuildTargetGroup.Android, true);

Assets/HTC.UnityPlugin/ViveInputUtility/Scripts/Editor/VRPlatformSettings/WindowsMRSettings.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ public override bool support
7878
get
7979
{
8080
#if UNITY_2019_3_OR_NEWER
81-
return canSupport && VIUSettings.activateUnityXRModule && XRPluginManagementUtils.IsXRLoaderEnabled(WINDOWSMR_XR_LOADER_NAME, requirdPlatform);
81+
return canSupport && VIUSettings.activateUnityXRModule && XRPluginManagementUtils.IsXRLoaderEnabled(WINDOWSMR_XR_LOADER_NAME, WINDOWSMR_XR_LOADER_CLASS_NAME, requirdPlatform);
8282
#elif UNITY_2018_2_OR_NEWER
8383
return canSupport && VIUSettings.activateUnityNativeVRModule && WindowsMRSDK.enabled;
8484
#else

Assets/HTC.UnityPlugin/ViveInputUtility/Scripts/Editor/XRPluginManagementUtils.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ namespace HTC.UnityPlugin.Vive
1919
{
2020
public static class XRPluginManagementUtils
2121
{
22-
public static bool IsXRLoaderEnabled(string loaderName, BuildTargetGroup buildTargetGroup)
22+
public static bool IsXRLoaderEnabled(string loaderName, string loaderClassName, BuildTargetGroup buildTargetGroup)
2323
{
2424
#if VIU_XR_GENERAL_SETTINGS
2525
XRGeneralSettings xrSettings = XRGeneralSettingsPerBuildTarget.XRGeneralSettingsForBuildTarget(buildTargetGroup);
@@ -35,7 +35,7 @@ public static bool IsXRLoaderEnabled(string loaderName, BuildTargetGroup buildTa
3535

3636
foreach (XRLoader loader in xrSettings.AssignedSettings.loaders)
3737
{
38-
if (loader.name == loaderName)
38+
if (loader.name == loaderName || loader.name == loaderClassName)
3939
{
4040
return true;
4141
}
@@ -44,7 +44,7 @@ public static bool IsXRLoaderEnabled(string loaderName, BuildTargetGroup buildTa
4444
return false;
4545
}
4646

47-
public static bool OnlyOneXRLoaderEnabled(string loaderName, BuildTargetGroup buildTargetGroup)
47+
public static bool OnlyOneXRLoaderEnabled(string loaderName, string loaderClassName, BuildTargetGroup buildTargetGroup)
4848
{
4949
#if VIU_XR_GENERAL_SETTINGS
5050
XRGeneralSettings xrSettings = XRGeneralSettingsPerBuildTarget.XRGeneralSettingsForBuildTarget(buildTargetGroup);
@@ -59,7 +59,7 @@ public static bool OnlyOneXRLoaderEnabled(string loaderName, BuildTargetGroup bu
5959
}
6060

6161
var loaders = xrSettings.AssignedSettings.loaders;
62-
return loaders.Count == 1 && loaders[0].name == loaderName;
62+
return loaders.Count == 1 && (loaders[0].name == loaderName || loaders[0].name == loaderClassName);
6363
#else
6464
return false;
6565
#endif

0 commit comments

Comments
 (0)