Skip to content

Migrate the client configs#183

Draft
ferriarnus wants to merge 17 commits into
Vivecraft:Multiloader-1.20from
ferriarnus:config
Draft

Migrate the client configs#183
ferriarnus wants to merge 17 commits into
Vivecraft:Multiloader-1.20from
ferriarnus:config

Conversation

@ferriarnus

Copy link
Copy Markdown
Member

Moving the client settings to the same system as the server configs

@Techjar

Techjar commented Oct 20, 2023

Copy link
Copy Markdown
Collaborator

What about all the existing GUIs with localized tooltips? And what about everyone's existing options files? I dunno, this just kinda seems like a "if it ain't broke don't fix it" situation.

@ferriarnus

Copy link
Copy Markdown
Member Author

I somewhat agree with you that working stuff should be left alone, however, having multiple systems for configs is a bit annoying. I've not looked into migrating the old ones, as I'm unsure if it's a big issue. For the guis, same as before: There's nothing really wrong with them, but multiple systems is hard to maintain.

@fayer3

fayer3 commented Oct 20, 2023

Copy link
Copy Markdown
Member

we can convert the old guis to use the new config system

@Techjar

Techjar commented Nov 1, 2023

Copy link
Copy Markdown
Collaborator

I guess I'll just be sad to see my VRSettings framework go away. I spent a lot of time refactoring it into an easy-to-work-with state. (You guys should have seen the old system lmao)

@ferriarnus

Copy link
Copy Markdown
Member Author

Yeah I get that, but I feel that toml is a bit of a nicer format (and is used by other mods so users will be familiar with it). I'm not a big fan of the massive enum, and annotations made it a bit more complex then needed imo. But the gui's can stay yeah. It's just that I wanted the server and client configs to have the same backend (and one which was hopefully less complex)

@fayer3

fayer3 commented Nov 1, 2023

Copy link
Copy Markdown
Member

yeah, we can keep the gui for now

@Techjar

Techjar commented Nov 1, 2023

Copy link
Copy Markdown
Collaborator

Yeah I don't think mod menu is as organized or user-friendly for the amount of settings we have, so at least keeping the GUI is kind of necessary. We'll have to convert all the localization strings though.

@Techjar

Techjar commented Nov 1, 2023

Copy link
Copy Markdown
Collaborator

annotations made it a bit more complex then needed imo

The reason for annotations was to avoid having to use getIntValue() or whatever all over the place. It can be used as just a regular field with the actual type. I'm still not a fan of the Fabric config system for that reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants