Fixes

Author: ChunkTreasure1

Engine/Source/Sandbox/Private/Sandbox/Sandbox.cpp

@@ -518,7 +518,6 @@ void Sandbox::OpenScene(Volt::AssetHandle sceneHandle)
 	SelectionManager::DeselectAll();
 
 	//load new scene
-	if (!isSameScene)
 	{
 		Volt::SceneContainer* newSceneContainer = m_sceneManager->LoadScene(sceneHandle);
 
@@ -540,11 +539,6 @@ void Sandbox::OpenScene(Volt::AssetHandle sceneHandle)
 		m_sceneContainer = newSceneContainer;
 		m_runtimeScene = newSceneContainer->GetScene();
 	}
-	else
-	{
-		// Reload the scene.
-		g_assetManager->ReloadAsset(sceneHandle);
-	}
 
 	SetupNewSceneData();
 	m_runtimeScene->LoadEntities();

Engine/Source/Volt-Application/Private/Volt-Application/UI/ImGuiSubSystem.cpp

@@ -4,6 +4,7 @@
 #include "Volt-Application/UI/UIUtility.h"
 #include "Volt-Application/UI/UIFonts.h"
 #include "Volt-Application/BaseApplication.h"
+#include "Volt-Application/ApplicationRenderer.h"
 
 #include <CoreUtilities/ConsoleVariableRegistry.h>
 #include <Volt-ImGui/ImGuiImplementation.h>
@@ -15,6 +16,8 @@
 #include <WindowModule/WindowManager.h>
 #include <WindowModule/Window.h>
 
+#include <SubSystem/SubSystemManager.h>
+
 #include <EventSystem/ApplicationEvents.h>
 #include <EventSystem/EventSystem.h>
 
@@ -121,6 +124,8 @@ namespace Volt
 			WindowManager::Get().Present();
 		}
 
+		ApplicationRenderer* applicationRenderer = SubSystemManager::GetSubSystem<ApplicationRenderer>();
+
 		bool hasCalledCallback = false;
 
 		while (m_isBlockingActive)
@@ -132,6 +137,8 @@ namespace Volt
 			AppPreRenderEvent preRenderEvent(BaseApplication::Get().GetFrameIndex());
 			EventSystem::DispatchEvent(preRenderEvent);
 
+			applicationRenderer->PreRender(preRenderEvent.GetFrameIndex());
+
 			m_imguiImplementation->Begin();
 
 			if (!hasCalledCallback && onEnterCallback)

Engine/Source/Volt-Application/Public/Volt-Application/ApplicationRenderer.h

@@ -32,11 +32,14 @@ namespace Volt
 		static void GetSubSystemDependencies(SubSystemDependencyList& outDependencies);
 		VT_DECLARE_SUBSYSTEM("{6596CB16-B988-421B-BC68-7F01DCA6D758}"_guid);
 
+		// #Note: This should not be public! Just a
+		//		  ducttape solution for imgui overlay!
+		void PreRender(uint64_t frameIndex);
+
 	private:
 		void UpdateRenderScene(IRenderScene& renderScene, uint64_t frameIndex);
 		void RenderSceneRenderer(ISceneRenderer& sceneRenderer, float timestep);
 
-		void PreRender(uint64_t frameIndex);
 		void PostRender();
 
 		class SceneManager* m_sceneManager = nullptr;

Engine/Source/Volt-Renderer/Private/Volt-Renderer/SceneRendererBindless/SceneRendererBindless.cpp

@@ -50,6 +50,18 @@ namespace Volt
 		m_skyboxMesh = ShapeLibrary::GetCube();
 	}
 
+	SceneRendererBindless::~SceneRendererBindless()
+	{
+		if (m_renderGraphExecutionCounter)
+		{
+			JobSystem::WaitForAndDestroyCounter(m_renderGraphExecutionCounter);
+		}
+
+		m_renderScene->GetRenderSceneInstanceAddedDelegate().Remove(m_renderSceneInstanceAddedDelegateHandle);
+		m_renderScene->GetRenderSceneInstanceRemovedDelegate().Remove(m_renderSceneInstanceRemovedDelegateHandle);
+		m_renderScene->GetRenderSceneInstanceReSortDelegate().Remove(m_renderSceneInstanceReSortDelegateHandle);
+	}
+
 	void SceneRendererBindless::OnRender(float timestep)
 	{
 		if (!m_renderingCamera)

Engine/Source/Volt-Renderer/Public/Volt-Renderer/SceneRendererBindless/SceneRendererBindless.h

@@ -18,7 +18,7 @@ namespace Volt
 	{
 	public:
 		SceneRendererBindless(const SceneRendererInitializer& initializer, Ref<IRenderScene> renderScene);
-		~SceneRendererBindless() override = default;
+		~SceneRendererBindless() override;
 
 		void OnRender(float timestep) override;
 		void Resize(uint32_t width, uint32_t height) override;