fix(server-hono): require server-core schema factory release#1230
fix(server-hono): require server-core schema factory release#1230omeraplak wants to merge 1 commit into
Conversation
|
| Name | Type |
|---|---|
| @voltagent/server-core | Patch |
| @voltagent/server-hono | Patch |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
📝 WalkthroughWalkthroughUpdates the Changes
Possibly related PRs
Poem
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This comment has been minimized.
This comment has been minimized.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.changeset/silver-rules-report.md (1)
8-10: Consider clarifying the changeset narrative.The phrase "Publishes the
createServerCoreSchemasexport" might suggest thatserver-coreis adding the export in this changeset, when in fact the export already exists inserver-core@2.1.15and this PR only updatesserver-hono's dependency floor to require it.✍️ Alternative wording for clarity
-Publishes the `createServerCoreSchemas` export used by `@voltagent/server-hono` to build Swagger -schemas with the active Zod instance, and updates `server-hono` to require a `server-core` release -that provides the runtime export. +Updates `@voltagent/server-hono` to require `server-core@^2.1.15`, which provides the +`createServerCoreSchemas` export needed to build Swagger schemas with the active Zod instance.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.changeset/silver-rules-report.md around lines 8 - 10, The changeset text is ambiguous about where createServerCoreSchemas was introduced; update the narrative to state that createServerCoreSchemas already exists in server-core@2.1.15 and this PR only tightens server-hono's dependency to require that release (i.e., “Bumps server-hono to require server-core@>=2.1.15 so it can use the existing createServerCoreSchemas runtime export”), mentioning createServerCoreSchemas, server-core@2.1.15, and server-hono to make the intent explicit.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/server-hono/package.json`:
- Line 13: The package.json currently pins "@voltagent/server-core" to a
non-existent version "^2.1.15", which will break installs; update the dependency
entry for "@voltagent/server-core" to use the published version string "^2.1.14"
(or wait and change to "^2.1.15" only after that version is published) so that
the dependency resolves correctly and exports like createServerCoreSchemas
remain available.
---
Nitpick comments:
In @.changeset/silver-rules-report.md:
- Around line 8-10: The changeset text is ambiguous about where
createServerCoreSchemas was introduced; update the narrative to state that
createServerCoreSchemas already exists in server-core@2.1.15 and this PR only
tightens server-hono's dependency to require that release (i.e., “Bumps
server-hono to require server-core@>=2.1.15 so it can use the existing
createServerCoreSchemas runtime export”), mentioning createServerCoreSchemas,
server-core@2.1.15, and server-hono to make the intent explicit.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 5480e556-f586-434d-aa33-8c2d86624161
📒 Files selected for processing (2)
.changeset/silver-rules-report.mdpackages/server-hono/package.json
| "@voltagent/mcp-server": "^2.0.2", | ||
| "@voltagent/resumable-streams": "^2.0.1", | ||
| "@voltagent/server-core": "^2.1.14", | ||
| "@voltagent/server-core": "^2.1.15", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Verify server-core 2.1.15 exists and exports createServerCoreSchemas
# Check if version 2.1.15 is published
echo "=== Checking published versions of `@voltagent/server-core` ==="
npm view `@voltagent/server-core` versions --json | jq -r '.[]' | grep -E '^2\.1\.(14|15|16)$'
# Check package.json version in server-core
echo -e "\n=== Current server-core package version ==="
cat packages/server-core/package.json | jq -r '.version'
# Check if createServerCoreSchemas is exported from server-core
echo -e "\n=== Verifying createServerCoreSchemas export ==="
rg -n "export.*createServerCoreSchemas" packages/server-core/
# Check the schemas file that should export it
echo -e "\n=== Checking agent.schemas.ts export ==="
fd -t f "agent.schemas.ts" packages/server-core/ --exec cat {}Repository: VoltAgent/voltagent
Length of output: 22029
Version 2.1.15 of @voltagent/server-core does not exist. Only version 2.1.14 is currently published. The dependency specification "^2.1.15" will fail to resolve during installation. Either downgrade to "^2.1.14" or ensure version 2.1.15 is published before merging (note: createServerCoreSchemas is correctly exported when the version is available).
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/server-hono/package.json` at line 13, The package.json currently
pins "@voltagent/server-core" to a non-existent version "^2.1.15", which will
break installs; update the dependency entry for "@voltagent/server-core" to use
the published version string "^2.1.14" (or wait and change to "^2.1.15" only
after that version is published) so that the dependency resolves correctly and
exports like createServerCoreSchemas remain available.
1 participant
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
What is the current behavior?
@voltagent/server-hono@2.0.12importscreateServerCoreSchemasfrom@voltagent/server-core, but its dependency range still allows installs to resolve aserver-coreversion that does not publish that runtime export. That can produce:What is the new behavior?
Updates the existing hotfix changeset so both
@voltagent/server-coreand@voltagent/server-honoreceive patch releases, and raises theserver-honodependency floor for@voltagent/server-coreto^2.1.15.This makes the follow-up
server-honopatch release resolve against aserver-corerelease that providescreateServerCoreSchemas.fixes #1222
Notes for reviewers
This is a release metadata hotfix only; no runtime code changed in this PR, so no runtime tests were added.
Validation:
node -e "JSON.parse(require('fs').readFileSync('packages/server-hono/package.json','utf8'))"pnpm exec prettier --check .changeset/silver-rules-report.md packages/server-hono/package.json