Skip to content

Commit fe27561

Browse files
committed
refactor: updated sms imports
1 parent c247b1d commit fe27561

5 files changed

Lines changed: 21 additions & 23 deletions

File tree

sms/send-express.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ require('dotenv').config({ path: __dirname + '/../.env' });
22

33
const VONAGE_API_KEY = process.env.VONAGE_API_KEY;
44
const VONAGE_API_SECRET = process.env.VONAGE_API_SECRET;
5-
const VONAGE_FROM_NUMBER = process.env.VONAGE_FROM_NUMBER;
5+
const SMS_SENDER_ID = process.env.SMS_SENDER_ID;
66

77
const express = require('express');
88
const bodyParser = require('body-parser');
@@ -21,9 +21,8 @@ const vonage = new Vonage({
2121
});
2222

2323
app.post('/send', (req, res) => {
24-
// Sending SMS via Vonage
2524
vonage.message.send(new SMS({
26-
from: VONAGE_FROM_NUMBER,
25+
from: SMS_SENDER_ID,
2726
to: req.body.toNumber,
2827
text: req.body.message,
2928
}))

sms/send-signed-sms.js

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,31 +2,30 @@ require('dotenv').config({ path: __dirname + '/../.env' });
22

33
const VONAGE_API_KEY = process.env.VONAGE_API_KEY;
44
const VONAGE_API_SECRET = process.env.VONAGE_API_SECRET;
5-
const VONAGE_API_SIGNATURE_SECRET = process.env.VONAGE_API_SIGNATURE_SECRET;
6-
const TO_NUMBER = process.env.VONAGE_TO_NUMBER;
7-
const FROM_NUMBER = process.env.VONAGE_FROM_NUMBER;
5+
const SMS_SIGNATURE = process.env.SMS_SIGNATURE;
6+
const SMS_TO_NUMBER = process.env.VONAGE_SMS_TO_NUMBER;
7+
const SMS_SENDER_ID = process.env.VONAGE_SMS_SENDER_ID;
88

99
const { Vonage } = require('@vonage/server-sdk');
1010

1111
const vonage = new Vonage({
1212
apiKey: VONAGE_API_KEY,
1313
apiSecret: VONAGE_API_SECRET,
14+
// By passing in the signature, the SDK will sign the request for you
15+
// Isn't that neat?!
1416
signature: {
15-
secret: VONAGE_API_SIGNATURE_SECRET,
17+
secret: SMS_SIGNATURE,
1618
algorithm: 'md5hash',
1719
},
1820
});
1921

20-
const from = FROM_NUMBER;
21-
const to = TO_NUMBER;
22-
const text = 'A text message sent using the Vonage SMS API';
2322

2423
const sendMessage = async () => {
2524
try {
2625
const result = await vonage.sms.send({
27-
from: from,
28-
to: to,
29-
text: text,
26+
from: SMS_SENDER_ID,
27+
to: SMS_TO_NUMBER,
28+
text: 'A text message sent using the Vonage SMS API',
3029
});
3130

3231
console.log('Message sent successfully.');

sms/send-unicode-sms.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ require('dotenv').config({ path: __dirname + '/../.env' });
22

33
const VONAGE_API_KEY = process.env.VONAGE_API_KEY;
44
const VONAGE_API_SECRET = process.env.VONAGE_API_SECRET;
5-
const TO_NUMBER = process.env.VONAGE_TO_NUMBER;
6-
const VONAGE_BRAND_NAME = process.env.VONAGE_BRAND_NAME;
5+
const SMS_TO_NUMBER = process.env.VONAGE_SMS_TO_NUMBER;
6+
const SMS_SENDER_ID = process.env.SMS_SENDER_ID;
77

88
const { Vonage } = require('@vonage/server-sdk');
99

@@ -12,8 +12,8 @@ const vonage = new Vonage({
1212
apiSecret: VONAGE_API_SECRET,
1313
});
1414

15-
const from = VONAGE_BRAND_NAME;
16-
const to = TO_NUMBER;
15+
const from = SMS_SENDER_ID;
16+
const to = SMS_TO_NUMBER;
1717
const text = 'こんにちは世界';
1818
const type = 'unicode';
1919

sms/send.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ require('dotenv').config({ path: __dirname + '/../.env' });
22

33
const VONAGE_API_KEY = process.env.VONAGE_API_KEY;
44
const VONAGE_API_SECRET = process.env.VONAGE_API_SECRET;
5-
const TO_NUMBER = process.env.VONAGE_TO_NUMBER;
6-
const VONAGE_BRAND_NAME = process.env.VONAGE_BRAND_NAME;
5+
const SMS_TO_NUMBER = process.env.VONAGE_SMS_TO_NUMBER;
6+
const SMS_SENDER_ID = process.env.SMS_SENDER_ID;
77

88
const { Vonage } = require('@vonage/server-sdk');
99

@@ -12,8 +12,8 @@ const vonage = new Vonage({
1212
apiSecret: VONAGE_API_SECRET,
1313
});
1414

15-
const from = VONAGE_BRAND_NAME;
16-
const to = TO_NUMBER;
15+
const from = SMS_SENDER_ID;
16+
const to = SMS_TO_NUMBER;
1717
const text = 'A text message sent using the Vonage SMS API';
1818

1919
vonage.sms.send({ to, from, text })

sms/verify-signed-sms.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
require('dotenv').config({ path: __dirname + '/../.env' });
22

3-
const VONAGE_API_SIGNATURE_SECRET = process.env.VONAGE_API_SIGNATURE_SECRET;
3+
const VONAGE_SIGNATURE_SECRET = process.env.VONAGE_SIGNATURE_SECRET;
44

55
const { Vonage } = require('@vonage/server-sdk');
66

@@ -24,7 +24,7 @@ const handleInboundSms = (request, response) => {
2424
if (Vonage.sms.verifySignature(
2525
sig,
2626
params,
27-
VONAGE_API_SIGNATURE_SECRET,
27+
VONAGE_SIGNATURE_SECRET,
2828
'md5hash', // one of md5hash, md5, sha1, sha256, or sha512
2929
)) {
3030
console.log('Valid signature');

0 commit comments

Comments
 (0)