Commit 4dc0808
fix: non-ASCII Discord names render as boxes in test-connection status
User reported their test-connection label showed "Connected as □□□□□"
where their actual Discord name has non-ASCII characters. Three
layered fixes, all in the same v0.1.9 release (commit goes on top of
f3df6a1, no tag yet).
PRIMARY (the user-visible fix):
SettingsPanel labels that display user-supplied strings now render
via GDI / Uniscribe instead of GDI+ / Graphics.DrawString. GDI does
proper Unicode font fallback — when a glyph isn't in the declared
font (Segoe UI), Windows falls back through Microsoft YaHei (CJK),
Segoe UI Symbol, Segoe UI Emoji, etc. GDI+ has no fallback chain
and renders missing glyphs as tofu boxes (□).
Applied to four labels that show user data: _testStatusLabel,
_currentCharLabel, _uploadStatusLabel, _captureLabel — via a small
EnableUnicodeFontFallback() helper that sets
UseCompatibleTextRendering = false.
Application.SetCompatibleTextRenderingDefault is the process-wide
switch but ACT owns that — we can only set this per-label.
DEFENSIVE — UTF-8 decoding:
HttpContent.ReadAsStringAsync on .NET Framework 4.8 has a
long-standing charset-fallback issue when the server omits
charset=utf-8 in Content-Type. FastAPI's JSONResponse intentionally
omits it (RFC 8259 mandates UTF-8 for application/json), which hits
the fallback. Replaced with ReadAsByteArrayAsync + explicit
Encoding.UTF8.GetString in a new ReadBodyUtf8Async helper. Same
result on every framework version.
dotnet/runtime#28658
DEFENSIVE — JSON escape handling:
ExtractJsonString's escape branch took the NEXT char literally
rather than decoding it. \uXXXX therefore became the literal text
"uXXXX", \n became literal "n", etc. FastAPI's ensure_ascii=False
means we don't hit this in production today, but any other JSON
producer (or a server config change) would silently bite. Now
handles every escape from RFC 8259 § 7:
\" \ \/ \b \f \n \r \t \uXXXX
Explicit hex-digit validation on \uXXXX — caught in test that
NumberStyles.HexNumber tolerates trailing whitespace, so "\u4f6 bar"
would otherwise have silently parsed as U+04F6 (Cyrillic Komi Gha)
instead of returning null for the malformed input.
6 new tests in UploadClientTests pinning every escape and the
real-world raw-UTF-8 happy path. Total 131/131.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent f3df6a1 commit 4dc0808
3 files changed
Lines changed: 173 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
116 | 116 | | |
117 | 117 | | |
118 | 118 | | |
119 | | - | |
| 119 | + | |
120 | 120 | | |
121 | 121 | | |
122 | 122 | | |
| |||
212 | 212 | | |
213 | 213 | | |
214 | 214 | | |
215 | | - | |
| 215 | + | |
216 | 216 | | |
217 | 217 | | |
218 | 218 | | |
| |||
258 | 258 | | |
259 | 259 | | |
260 | 260 | | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
261 | 268 | | |
262 | 269 | | |
263 | 270 | | |
| |||
276 | 283 | | |
277 | 284 | | |
278 | 285 | | |
279 | | - | |
| 286 | + | |
| 287 | + | |
280 | 288 | | |
281 | | - | |
282 | | - | |
| 289 | + | |
283 | 290 | | |
284 | 291 | | |
285 | | - | |
286 | | - | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
287 | 344 | | |
288 | 345 | | |
289 | 346 | | |
290 | 347 | | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
291 | 366 | | |
292 | 367 | | |
293 | 368 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
230 | 230 | | |
231 | 231 | | |
232 | 232 | | |
| 233 | + | |
233 | 234 | | |
234 | 235 | | |
235 | 236 | | |
| |||
246 | 247 | | |
247 | 248 | | |
248 | 249 | | |
| 250 | + | |
249 | 251 | | |
250 | 252 | | |
251 | 253 | | |
| |||
280 | 282 | | |
281 | 283 | | |
282 | 284 | | |
| 285 | + | |
283 | 286 | | |
284 | 287 | | |
285 | 288 | | |
| |||
306 | 309 | | |
307 | 310 | | |
308 | 311 | | |
| 312 | + | |
309 | 313 | | |
310 | 314 | | |
311 | 315 | | |
| |||
575 | 579 | | |
576 | 580 | | |
577 | 581 | | |
| 582 | + | |
| 583 | + | |
| 584 | + | |
| 585 | + | |
| 586 | + | |
| 587 | + | |
| 588 | + | |
| 589 | + | |
| 590 | + | |
| 591 | + | |
| 592 | + | |
| 593 | + | |
| 594 | + | |
| 595 | + | |
| 596 | + | |
| 597 | + | |
| 598 | + | |
| 599 | + | |
| 600 | + | |
578 | 601 | | |
579 | 602 | | |
580 | 603 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
122 | 122 | | |
123 | 123 | | |
124 | 124 | | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
125 | 193 | | |
126 | 194 | | |
127 | 195 | | |
| |||
0 commit comments