Update strategy signals and timers; fix comments language; minor tuning

Author: VoxHash

forexsmartbot/strategies/ml_adaptive_supertrend.py

@@ -184,25 +184,37 @@ def signal(self, df: pd.DataFrame) -> int:
 
         # Only trade on STRONG trend changes with multiple confirmations
         if direction != prev_direction:
-            # Wait for strong confirmation - price must be significantly above/below SuperTrend
+            # Wait for strong confirmation: price clearly above/below the SuperTrend line
             atr = float(row.get('ATR', 0))
             if atr > 0:
                 price_distance = abs(current_price - supertrend) / atr
 
-                # Balanced thresholds for good entries
-                if direction > 0 and current_price > supertrend and price_distance > 0.3:
-                    # Additional confirmation: price should be rising
+                # More aggressive thresholds to generate signals on trend change
+                if direction > 0 and current_price > supertrend and price_distance > 0.1:
+                    # Additional confirmation: positive momentum
                     price_change = current_price - float(prev['Close'])
                     if price_change > 0:
                         return 1  # Buy signal
-                elif direction < 0 and current_price < supertrend and price_distance > 0.3:
-                    # Additional confirmation: price should be falling
+                elif direction < 0 and current_price < supertrend and price_distance > 0.1:
+                    # Additional confirmation: negative momentum
                     price_change = current_price - float(prev['Close'])
                     if price_change < 0:
                         return -1  # Sell signal
-        
-        # No additional signals - only trade on very clear trend changes
-                
+
+        # NEW: Allow signals on confirmed price cross even without Direction change
+        # Rules: price crosses SuperTrend line + sufficient distance/ATR + momentum confirmation
+        atr = float(row.get('ATR', 0))
+        if atr > 0:
+            price_distance = abs(current_price - supertrend) / atr
+            price_change = current_price - float(prev['Close'])
+            
+            # Confirmed bullish cross
+            if current_price > supertrend and direction > 0 and price_distance > 0.1 and price_change > 0:
+                return 1
+            # Confirmed bearish cross
+            if current_price < supertrend and direction < 0 and price_distance > 0.1 and price_change < 0:
+                return -1
+
         return 0  # Hold
 
     def volatility(self, df: pd.DataFrame) -> Optional[float]:

forexsmartbot/ui/enhanced_main_window.py

@@ -1049,7 +1049,7 @@ def start_signal_generation(self, strategy, symbols):
             # Start real-time signal generation timer (less frequent to prevent freezing)
             self.signal_timer = QTimer()
             self.signal_timer.timeout.connect(lambda: self.generate_signals(strategy, symbols))
-            self.signal_timer.start(600000)  # Check every 10 minutes (reduced frequency)
+            self.signal_timer.start(300000)  # Check every 5 minutes (more frequent)
 
             # Start monitoring timer (less frequent)
             self.monitor_timer = QTimer()
@@ -1081,7 +1081,7 @@ def generate_signals(self, strategy, symbols):
                     current_time = datetime.now()
                     if symbol in self.signal_cooldown:
                         time_since_last = (current_time - self.signal_cooldown[symbol]).total_seconds()
-                        if time_since_last < 900:  # 15 minute cooldown
+                        if time_since_last < 600:  # 10 minute cooldown
                             continue
 
                     # Get current price (simplified to prevent blocking)