Outbox telemetry: rename ActivitySource + auto-register when tracing is enabled#235
Merged
Conversation
…-register it when tracing is enabled
|
Code review One issue found while checking for bugs and CLAUDE.md compliance. XML doc not updated for the In Per the project rule — "When modifying a public member, make sure to update the XML Documentation" — and this file's own convention (every (Posted as a summary comment — inline review comments are not available in this environment.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the outbox relay's tracing work out of the box. Follows #232 (merged).
ActivitySourcefrom"Vulthil.SharedKernel.Infrastructure"to"Vulthil.SharedKernel.Outbox"(Telemetry.ActivitySourceName) so it matches the package that emits it.AddOutboxEngine(←EnableOutboxProcessing), gated onOutboxProcessingOptions.EnableTracing(default on) — soOutboxPublishingspans reach the app's configured tracer with no manualAddSource/wildcard. WhenEnableTracingis off, registration is skipped entirely (and the processor emits no spans either).AddVulthilOutboxInstrumentation()TracerProviderBuilderhelper (mirrors the RabbitMq package'sAddVulthilMessagingInstrumentation()) for manual tracer-provider setups; the engine calls it internally.OutboxProcessingOptions.EnableTracingis now settable (init→set) so the gate can read it from the configure callback.OpenTelemetry.Api+OpenTelemetry.Extensions.Hostingto the (previously OTel-free) engine package. PublicAPI + docs updated.Verification
Full Release build clean; WebApi.Tests 8/8 (confirms the engine's
AddOpenTelemetry()merges with the app/ServiceDefaults' own at runtime).