Test harness fidelity: consumer retry, Fault<T>, and request timeout#246
Merged
Conversation
…ad and honor nullable CorrelationId
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Closes the
Vulthil.Messaging.TestHarnessfidelity gaps so behaviour verified against the in-memory harness matches real RabbitMQ.TestHarness
RabbitMqConsumerWorker, without the real back-off delays). A throwing consumer no longer propagates to the publisher.Fault<T>emission — on retry exhaustion aFault<TMessage>is published (captured and delivered in-process), soharness.Published<Fault<T>>()works.Messaging.Request.Timeout(matching the real requester), notError.NotFound.RetryCount/Redelivered— populated from the attempt number instead of hardcoded0/false.Behaviour changes (docs + tests updated): a one-way consumer that throws lets the publish/send succeed and emits a fault; a no-consumer request times out.
Messaging-core cleanups (first commit)
IMessageConfigurationProvider.GetMessageConfiguration<T>()overload.MessageContext.CorrelationIdis now nullable, honouring theIMessageContextcontract (dropped the?? string.Emptycoercion).Tests
3 new TestHarness tests (fault emission, retry-with-incrementing-
RetryCountrecovery, no-consumer timeout); full TestHarness, core-messaging, and RabbitMq suites green locally (net9.0 + net10.0).🤖 Generated with Claude Code