Messaging metrics (outbox + inbox) and a clear no-transport startup error#247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two messaging-core improvements on one branch (off the merged main).
Observability — metrics (main change)
Mirrors the existing tracing setup, for metrics:
Meter "Vulthil.SharedKernel.Outbox"withvulthil.outbox.relayed/vulthil.outbox.failedcounters (inOutboxProcessor);EnableMetricsflag onOutboxProcessingOptions(default on); auto-registered byAddOutboxEngine; manualAddVulthilOutboxInstrumentation()on aMeterProviderBuilder.Meter "Vulthil.Messaging.Inbox"withvulthil.inbox.processed/duplicate_skipped/missing_keycounters (inIdempotentConsumeFilter);EnableMetricsonInboxOptions; auto-registered byAddRelationalInbox/AddCosmosInbox; manualAddVulthilInboxInstrumentation().Deferred (need a store-level count / terminal-marking hook): the outbox
pendingbacklog gauge and adead_letteredcounter.Clear startup error when no transport is configured
ConsumerHostedServicenow throws a clear "No messaging transport is registered — call.UseRabbitMq(...)…" at host-start instead of an obscure DI failure. Placed at host-start (not insideAddMessaging) soReplaceTransportWithTestHarness, which registers the transport afterwards, still works.Tests
MeterListenertests for both meters and a no-transport startup-error test; full unit suites green locally (net9.0 + net10.0).🤖 Generated with Claude Code