Fix four CQRS pipeline bugs in Vulthil.SharedKernel.Application (T01)#280
Merged
Conversation
…andler disposal, and error logging in the CQRS pipeline
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Owner
Author
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Application-layer CQRS pipeline, two independently confirmed, two re-verified from reports.
always fell through to throw ValidationException, contradicting its own XML doc.
two handler interfaces silently dropped the second.
disposal (registering the concrete type in DI directly was rejected — it would make the handler
resolvable outside the pipeline, breaking a documented invariant and an existing test).
ValidationError's inner Errors list from the log scope.
Test plan
dotnet build src/Vulthil.SharedKernel.Application— net9.0 & net10.0, 0 warningsVulthil.SharedKernel.Application.Tests— 26/26 pass on net9.0 and net10.0Vulthil.SharedKernel.Tests(11/11) andVulthil.Results.Tests(192/192) pass