Skip to content

Fix four CQRS pipeline bugs in Vulthil.SharedKernel.Application (T01)#280

Merged
Vulthil merged 1 commit into
mainfrom
fix/application-pipeline-bugs
Jul 4, 2026
Merged

Fix four CQRS pipeline bugs in Vulthil.SharedKernel.Application (T01)#280
Vulthil merged 1 commit into
mainfrom
fix/application-pipeline-bugs

Conversation

@Vulthil

@Vulthil Vulthil commented Jul 4, 2026

Copy link
Copy Markdown
Owner

Summary

  • Fixes T01 (docs/design/tasks/T01-application-validation-and-registration.md): four bugs in the
    Application-layer CQRS pipeline, two independently confirmed, two re-verified from reports.
  • ValidationPipelineBehavior never actually returned a failed Result on validation failure — it
    always fell through to throw ValidationException, contradicting its own XML doc.
  • HandlerRegistrar only registered the first IHandler<,> a class implemented; a class implementing
    two handler interfaces silently dropped the second.
  • Handlers created via ActivatorUtilities were never disposed; InnerHandlerAdapter now forwards
    disposal (registering the concrete type in DI directly was rejected — it would make the handler
    resolvable outside the pipeline, breaking a documented invariant and an existing test).
  • RequestLoggingPipelineBehavior serialized errors using the static Error type, dropping
    ValidationError's inner Errors list from the log scope.

Test plan

  • dotnet build src/Vulthil.SharedKernel.Application — net9.0 & net10.0, 0 warnings
  • Vulthil.SharedKernel.Application.Tests — 26/26 pass on net9.0 and net10.0
  • New tests confirmed to fail against the old (unfixed) source, pass against the fix
  • Vulthil.SharedKernel.Tests (11/11) and Vulthil.Results.Tests (192/192) pass
  • PublicAPI.Shipped/Unshipped.txt unchanged across the repo

…andler disposal, and error logging in the CQRS pipeline
@Vulthil Vulthil added the backport v1.0 Backport this PR to the v1.0 servicing branch label Jul 4, 2026
@claude

claude Bot commented Jul 4, 2026

Copy link
Copy Markdown

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@Vulthil
Vulthil merged commit 7a040b4 into main Jul 4, 2026
7 checks passed
@Vulthil

Vulthil commented Jul 4, 2026

Copy link
Copy Markdown
Owner Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport v1.0 Backport this PR to the v1.0 servicing branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant