Capture domain events and validate outbox delay options for sync SaveChanges callers#293
Merged
Merged
Conversation
…idate the relay delay bounds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DomainEventsToOutboxMessageSaveChangesInterceptornow also overrides the synchronousSavingChanges/SavedChangesEF Core hooks (previously only the async ones), so a bare synchronousSaveChanges()call captures domain events and wakes the relay identically to the async path instead of silently dropping them.AddOutboxEnginenow validates thatMaxDelaySecondsis greater than or equal toOutboxProcessingDelaySecondsat startup, so a contradictory configuration (e.g. base delay 100s, max 1s) fails fast instead of silently clamping every poll delay to the max.Verification
dotnet buildon the full solution: 0 errors, PublicAPI analyzers green.Backport to v1.0: no — adds public API (patch-ineligible).