Repo hygiene: dependabot cleanup, solution-file fixes, single-source coverage script#336
Merged
Conversation
… CI-shared coverage script
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dockerecosystem block fromdependabot.yml(no Dockerfile exists in the repo) and renamed itsgithub-actionsgroup fromdotnettoactionsto match what it actually groups.watch,watch-samples,test-reports) with a singleeng/coverage.ps1thatci.ymlnow invokes directly for its coverage step, instead of duplicating the samedotnet test/reportgeneratorcommands in two places. Local runs and CI can no longer drift apart.Vulthil.SharedKernel.slnx: removed solution items pointing at gitignored build output (TestReports/Cobertura.xml,TestReports/index.html, which dangled on a fresh clone), added the two workflow files it was missing (backport.yml,codeql.yml), and pointed its/eng/folder at the newcoverage.ps1.No behavior changes to the CI-observable output:
ci.yml's "Test with coverage" step now runs./eng/coverage.ps1 -NoBuild, which contains the exact samedotnet test/dotnet tool restore/dotnet reportgeneratorcommands the three replaced steps ran, so the coverage report/badge artifacts are produced identically.cliff.toml,Directory.Packages.props, the Microsoft.OpenApi pins, and the NU1903 SQLitePCLRaw suppression were all re-checked and are intentionally untouched (the SQLitePCLRaw advisory still has no patched release upstream as of this PR).Test plan
dotnet buildagainst the solution succeeds with 0 warnings/errorseng/coverage.ps1runs the intended commands in order and fails fast on the first non-zero exit (verified locally; container-backed test projects fail in this sandbox for lack of a Docker daemon, which correctly halts the script before report generation, same as the previous multi-step behavior)reportgeneratorcommand producesCoverageReport/index.htmlgiven available coverage dataci.ymlreviewed for YAML validity and step-list correctness (actionlintunavailable locally)Backport to v1.0: no — repo tooling only.