test: add first-party unit tests for Vulthil.xUnit and Vulthil.Extensions.Testing#345
Merged
Merged
Conversation
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/Vulthil.Extensions.Testing.TestscoveringPolling.WaitAsync(both the generic andnon-generic cores: immediate success, success-on-Nth-attempt, timeout error aggregation,
cancellation-vs-timeout distinction) and
HttpResponseMessageExtensions.GetResponseAsync<T>.tests/Vulthil.xUnit.TestscoveringBaseUnitTestCaselifecycle (lazy Target timing,Use/UseReal/UseRealFor, Initialize/Dispose hook ordering, disposal ordering),
HttpMockrulematching (URL, wildcard, headers, the predicate
On(...)overload, unmatched requests, reset),SanitizeDatabaseNameedge cases, andContainerHostbookkeeping via fakes (no Docker).BaseUnitTestCaseDisposalTestsfromVulthil.SharedKernel.Testsinto thenew project, since its subject is a
Vulthil.xUnittype./tests/Testing/folder, mirroring theexisting
/src/Testing/grouping.Verification
Vulthil.Extensions.Testing.Tests: 16/16 passing on both TFMs.Vulthil.xUnit.Tests: 45/45 passing on both TFMs.Vulthil.SharedKernel.Tests(post-relocation): 11/11 passing on both TFMs.PublicAPI.*.txtandCompatibilitySuppressions.xmlis unchanged.Backport to v1.0: no — test-only additions ship with the next release.