test: cover EntityFrameworkOutboxStore parallel publishing throttle and per-message outcome recording#346
Merged
Conversation
…nd per-message outcome recording
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EntityFrameworkOutboxStoreparallel-publishing throttle (EnableParallelPublishing/MaxDegreeOfParallelism), which previously had no tests against the real store — the existing coverage only exercised fakes that mirrored the semaphore pattern.ThrottlesParallelDispatchToTheConfiguredMaxDegreeOfParallelism: a gate-basedConcurrencyTrackingDispatcherparks dispatches until the cap is saturated, proving peak concurrent dispatches reach and never exceed the configuredMaxDegreeOfParallelism— deterministically, with no timing sleeps.RecordsEachMessageOutcomeIndividuallyWhenAParallelBatchHasAFailure: one failing dispatch in a parallel batch leaves the other rows' outcomes intact (ProcessedOnUtcset,RetryCount0, no error) while the failing row recordsRetryCount1 and its error without being dead-lettered.NewStorehelper with optional parallel-publishing parameters; test-only change, nosrc/modifications.Verification
--filter-classon the store test class for net9.0 and net10.0: 7/7 passed on both.Vulthil.SharedKernel.Outbox.EntityFrameworkCore.Testsproject: 12/12 on both TFMs, plus 3 repeat runs of the class to confirm the concurrency test is stable.Backport to v1.0: no