Dedupe outbox type resolution and RabbitMQ wire-message construction#348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolution, common BasicProperties fields, envelope serialization, producer activity
tags) into one shared internal builder used only within Vulthil.Messaging.RabbitMq;
the fields and error-handling scope that legitimately differ per operation (reply-to,
wire correlation id, persistence, expiration, serialization failure handling) stay in
each caller.
property/header extraction between the fault-snapshot and bare-JSON typed-context
paths.
transport replacement depends on.
Verification
Vulthil.Messaging.TestHarness.Tests, Vulthil.Messaging.Abstractions.Tests: all green on
net9.0 and net10.0, assertions unmodified.
API-compatibility errors against the 1.1.0 baseline.
revision (outbox type resolver, typed-context mapping) was reverted per review; all
remaining sharing is within a single assembly.
Backport to v1.0: no — internal refactor ships with the next release.