Deduplicate inbox registration and close inbox retention test gaps#349
Merged
Conversation
…d cover retention paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
and AddCosmosInbox into one internal core entry point; the store extensions now register
only their store type. The configure delegate now runs once eagerly (for the gates) plus
once deferred (for injected consumers), down from three invocations.
in both the inbox and outbox option types. On the outbox side this required adding explicit
lambda checks first for five constraints that were not actually mirrored anywhere else, to
keep validation behavior unchanged.
makes its configure parameter optional (PublicAPI.Shipped.txt updated in place; verified via
build and pack that this is accepted as a compatible change).
and DI-registration-level tests (options validation, enabled/disabled hosted-service gating)
that didn't exist for the inbox family before.
IdempotentConsumeFilter, and make the Cosmos retention sweep treat a concurrent sweeper's
DbUpdateConcurrencyException as progress instead of an error-level log.
Verification
SharedKernel.Outbox), plus downstream Outbox.EntityFrameworkCore and Messaging.Outbox suites
re-run as a sanity check.
against the 1.1.0 baseline for all four packages.
Backport to v1.0: no — internal dedup and tests ship with the next release.