Promote AddInboxCore to public API to replace cross-assembly internals#350
Merged
Conversation
…ing cross-assembly internals
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages — internals visible across shipped assemblies is no longer allowed.
keep working through ordinary public visibility instead. Its signature only ever exposed public types, so
nothing else needed to change. Documented it as a first-class extension point: a custom IIdempotencyStore
package registers its own store and then calls AddInboxCore to get the same retention sweep, metrics, and
TimeProvider wiring the first-party Relational/Cosmos stores get, and states the configure delegate's
invocation contract (once eagerly for the gates, once deferred for injected consumers).
the call resolves unchanged) alongside the retention/metrics/TimeProvider wiring assertions already used
for AddRelationalInbox.
Verification
extension's observable behavior is unchanged; this is a visibility promotion, not a behavior change.
and Vulthil.Messaging.Inbox.Cosmos: APICompat reports no breaking changes for all three, no compatibility
suppressions needed.
Backport to v1.0: no — additive public API ships with the next minor.