ci: auto-prune stale CompatibilitySuppressions.xml entries on baseline bump#352
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
and propagate-baseline-to-main right after each bumps
PackageValidationBaselineVersion (and after nuget.org has indexed the new
baseline package), so its changes ride in the same commit/PR as the bump.
baseline via
dotnet pack -p:ApiCompatGenerateSuppressionFile=true,redirected through ApiCompatSuppressionOutputFile so the real files are
never touched until proven safe. Only ever removes entries no longer
needed; if regeneration would add one anywhere, the job fails with the
exact entry and modifies nothing -- that means a real API break needs a
human suppression decision, not a silent auto-suppress.
setup-build composite (gated in the propagate job to match its existing
bumped-skip logic) and fetch-depth: 0 (Nerdbank.GitVersioning's
shallow-clone warning would otherwise become a hard failure under this
repo's TreatWarningsAsErrors). Both timeouts raised 35 -> 45 min for the
added dotnet pack cost.
Verification
byte-identical files (comments included); nothing written.
it back; the script detects that, writes nothing, and fails loudly.
file removed rather than left as an empty shell.
add-paths on both create-pull-request steps extended so pruned/deleted
suppression files ride the bump PR.
Backport to v1.0: no — release-automation change on the default branch only.