Align the .NET servicing train to 10.0.10/9.0.18 and hand-manage the Microsoft.OpenApi pin#355
Merged
Merged
Conversation
…ge the Microsoft.OpenApi pin
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
…ions.* pins literal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FrameworkVersionproperty (EF Core packages, Mvc.Testing, AspNetCore.OpenApi) moves 10.0.9 → 10.0.10 with its net9.0 leg 9.0.17 → 9.0.18, the eight literalMicrosoft.Extensions.*entries move 10.0.9 → 10.0.10, andMicroting.EntityFrameworkCore.MySqlmoves 10.0.9 → 10.0.10. Dependabot cannot raise a version property shared by multiple packages, so its PR bumped only the literals and would have shipped EF/ASP.NET Core at 10.0.9 next to Extensions at 10.0.10.Microsoft.OpenApipin's net10.0 leg 2.9.0 → 2.11.0 (staying on the GHSA-v5pm-xwqc-g5wc-patched 2.x line). The net9.0 leg stays 1.6.17, which is exactlyMicrosoft.AspNetCore.OpenApi9.0.18's own dependency floor (verified from its nuspec — ASP.NET Core 9 consumes the 1.x line, not 2.x). The 10.0.10 nuspec still floors at Microsoft.OpenApi 2.0.0, so the pin's removal condition (floor past 2.7.5) has not been met and the pin stays.Microsoft.OpenApifrom majors-only to all updates: dependabot flattens conditional MSBuild property definitions to a single value, so its deps PR rewrote the net9.0 leg 1.6.17 → 2.11.0 — pairing ASP.NET Core 9's OpenApi package with the incompatible 2.x line. The majors-only rule couldn't catch this (2.9.0 → 2.11.0 is a minor at the property's default leg), so the pin is now hand-managed; NuGetAudit still fails CI on real advisories regardless.Microsoft.Extensions.Http.Resilience/Microsoft.Extensions.ServiceDiscovery(their own 10.7 → 10.8 minor line) and the tooling/OTel/analyzer bumps — those stay with the dependabot PR, which shrinks to just that set on its next rebase.Verification
dotnet restore: clean — no NU1102, no new audit warnings../eng/coverage.ps1: Release build on both TFMs, all suites including the Docker-backed provider tests and the Aspire-hosted integration suite): 1569/1569 + 13/13 passed, 0 failed. One known-flaky Aspire-suite test failed once and passed on the scoped retry.PublicAPI*.txt/CompatibilitySuppressions.xml: untouched (dependency-only change).Backport to v1.0: no — v1.0 is advisory-only servicing; this is routine train alignment on main.
Note: why the Microsoft.Extensions.* entries stay literal
Consolidating them onto
$(FrameworkVersion)was attempted and reverted: the Aspire 13.x client integrations shipped in src (Aspire.RabbitMQ.Client and the three EF provider integrations) floorMicrosoft.Extensions.*at>= 10.0.8on BOTH TFMs, so a 9.x net9.0 leg is an NU1605 downgrade error (reproduced on a full build). The constraint is now documented inDirectory.Packages.propsnext to the pins.