Skip to content

Commit 20c5120

Browse files
committed
Merge pull request #28 from WASdev/tidy_todos
Remove a few TODOs which are no longer valid
2 parents 195fdb6 + 52102ac commit 20c5120

4 files changed

Lines changed: 3 additions & 21 deletions

File tree

server/src/main/java/com/ibm/ws/lars/rest/model/Asset.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,6 @@
2727
* Enforces the constrains on a JSON document to turn it into a Asset as required by the asset
2828
* service.
2929
*
30-
* TODO: client test suite failures<br>
31-
* - do we need a review object?<br>
32-
* - should a private asset skip the awaiting approval stage?
3330
*/
3431
public class Asset extends RepositoryObject {
3532

server/src/test/java/com/ibm/ws/lars/rest/DummyUriInfo.java

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -48,112 +48,96 @@ public URI getBaseUri() {
4848
/** {@inheritDoc} */
4949
@Override
5050
public URI getAbsolutePath() {
51-
// TODO Auto-generated method stub
5251
return null;
5352
}
5453

5554
/** {@inheritDoc} */
5655
@Override
5756
public UriBuilder getAbsolutePathBuilder() {
58-
// TODO Auto-generated method stub
5957
return null;
6058
}
6159

6260
/** {@inheritDoc} */
6361
@Override
6462
public UriBuilder getBaseUriBuilder() {
65-
// TODO Auto-generated method stub
6663
return null;
6764
}
6865

6966
/** {@inheritDoc} */
7067
@Override
7168
public List<Object> getMatchedResources() {
72-
// TODO Auto-generated method stub
7369
return null;
7470
}
7571

7672
/** {@inheritDoc} */
7773
@Override
7874
public List<String> getMatchedURIs() {
79-
// TODO Auto-generated method stub
8075
return null;
8176
}
8277

8378
/** {@inheritDoc} */
8479
@Override
8580
public List<String> getMatchedURIs(boolean arg0) {
86-
// TODO Auto-generated method stub
8781
return null;
8882
}
8983

9084
/** {@inheritDoc} */
9185
@Override
9286
public String getPath() {
93-
// TODO Auto-generated method stub
9487
return null;
9588
}
9689

9790
/** {@inheritDoc} */
9891
@Override
9992
public String getPath(boolean arg0) {
100-
// TODO Auto-generated method stub
10193
return null;
10294
}
10395

10496
/** {@inheritDoc} */
10597
@Override
10698
public MultivaluedMap<String, String> getPathParameters() {
107-
// TODO Auto-generated method stub
10899
return null;
109100
}
110101

111102
/** {@inheritDoc} */
112103
@Override
113104
public MultivaluedMap<String, String> getPathParameters(boolean arg0) {
114-
// TODO Auto-generated method stub
115105
return null;
116106
}
117107

118108
/** {@inheritDoc} */
119109
@Override
120110
public List<PathSegment> getPathSegments() {
121-
// TODO Auto-generated method stub
122111
return null;
123112
}
124113

125114
/** {@inheritDoc} */
126115
@Override
127116
public List<PathSegment> getPathSegments(boolean arg0) {
128-
// TODO Auto-generated method stub
129117
return null;
130118
}
131119

132120
/** {@inheritDoc} */
133121
@Override
134122
public MultivaluedMap<String, String> getQueryParameters() {
135-
// TODO Auto-generated method stub
136123
return null;
137124
}
138125

139126
/** {@inheritDoc} */
140127
@Override
141128
public MultivaluedMap<String, String> getQueryParameters(boolean arg0) {
142-
// TODO Auto-generated method stub
143129
return null;
144130
}
145131

146132
/** {@inheritDoc} */
147133
@Override
148134
public URI getRequestUri() {
149-
// TODO Auto-generated method stub
150135
return null;
151136
}
152137

153138
/** {@inheritDoc} */
154139
@Override
155140
public UriBuilder getRequestUriBuilder() {
156-
// TODO Auto-generated method stub
157141
return null;
158142
}
159143

server/src/test/java/com/ibm/ws/lars/rest/PersistenceBeanTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848

4949
public class PersistenceBeanTest {
5050

51-
// TODO read all this stuff from config somewhere
51+
// TODO Should the db name be configurable?
5252
private static final String DB_NAME = "testdb";
5353
private static final WriteConcern WRITE_CONCERN = WriteConcern.JOURNAL_SAFE;
5454

upload-lib/src/fat/java/com/ibm/ws/massive/esa/MassiveEsaTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1581,7 +1581,8 @@ public void testExtendedPackage() throws Throwable {
15811581

15821582
@Test
15831583
@Ignore
1584-
// TODO Story 144391 (port elastic search) must be delivered before the tests @Ignore can be removed
1584+
// LARS needs to support search before the tests @Ignore can be removed
1585+
// TODO: check whether the current mongo based search implementation is sufficient
15851586
/**
15861587
* Based on a small set of features make searches to see whether the correct results match each query
15871588
* @throws Throwable

0 commit comments

Comments
 (0)