Allow multiple pullsecrets during image auth (#843)

* Allow multi pullsecrets during image auth

* Address PR comments

* Add pull secret name to error log

Author: kabicin

internal/controller/webspherelibertyapplication_controller.go

@@ -1160,17 +1160,29 @@ func (r *ReconcileWebSphereLiberty) getContainerImageMetadata(reqLogger logr.Log
 	wlappSecrets := []corev1.Secret{}
 	var pullSecret *corev1.Secret
 	if wlapp.GetPullSecret() != nil {
-		pullSecret = &corev1.Secret{}
-		if err := r.GetClient().Get(context.TODO(), types.NamespacedName{Name: *wlapp.GetPullSecret(), Namespace: wlapp.GetNamespace()}, pullSecret); err != nil {
-			if kerrors.IsNotFound(err) {
-				reqLogger.Info("The instance pull secret specified does not exist")
-				pullSecret = nil
-			} else {
-				reqLogger.Error(err, "Failed to get the instance pull secret")
-				return "", nil, fmt.Errorf("Failed to get the instance pull secret: %v", err)
+		pullSecretString := strings.TrimSpace(*wlapp.GetPullSecret())
+		pullSecretNames := []string{}
+		if strings.Contains(pullSecretString, ",") {
+			pullSecretNames = strings.Split(pullSecretString, ",")
+		} else {
+			pullSecretNames = append(pullSecretNames, pullSecretString)
+		}
+		for _, pullSecretName := range pullSecretNames {
+			pullSecretName = strings.TrimSpace(pullSecretName)
+			pullSecret = &corev1.Secret{}
+			if err := r.GetClient().Get(context.TODO(), types.NamespacedName{Name: pullSecretName, Namespace: wlapp.GetNamespace()}, pullSecret); err != nil {
+				if kerrors.IsNotFound(err) {
+					reqLogger.Info(fmt.Sprintf("The instance pull secret %s does not exist", pullSecretName))
+					pullSecret = nil
+				} else {
+					reqLogger.Error(err, fmt.Sprintf("Failed to get the instance pull secret %s", pullSecretName))
+					return "", nil, fmt.Errorf("Failed to get the instance pull secret %s: %v", pullSecretName, err)
+				}
+			}
+			if pullSecret != nil {
+				wlappSecrets = append(wlappSecrets, *pullSecret)
 			}
 		}
-		wlappSecrets = append(wlappSecrets, *pullSecret)
 	}
 	return libertyimage.NewNamespaceCredentialsContext(reqLogger, wlappSecrets, wlapp.GetNamespace()).GetContainerImageMetadata(context.TODO(), imageRef, pullSecret, false)
 }