Trim spaces when processing pull secrets (#844)

* Use DecodeStringToList helper in pull secret validation

* Pull RCO/OLO main changes

Author: kabicin

go.mod

@@ -3,8 +3,8 @@ module github.com/WASdev/websphere-liberty-operator
 go 1.26
 
 require (
-	github.com/OpenLiberty/open-liberty-operator v0.8.1-0.20260306042107-9a3cb814041b
-	github.com/application-stacks/runtime-component-operator v1.0.0-20220602-0850.0.20260306040218-27cdcb5746cc
+	github.com/OpenLiberty/open-liberty-operator v0.8.1-0.20260318175607-71d13b9b323b
+	github.com/application-stacks/runtime-component-operator v1.0.0-20220602-0850.0.20260318005646-e267e0c1cb83
 	github.com/cert-manager/cert-manager v1.19.4
 	github.com/go-logr/logr v1.4.3
 	github.com/openshift/api v0.0.0-20260304172252-b0658d22beea

go.sum

@@ -2,12 +2,12 @@ github.com/Azure/go-ansiterm v0.0.0-20230124172434-306776ec8161 h1:L/gRVlceqvL25
 github.com/Azure/go-ansiterm v0.0.0-20230124172434-306776ec8161/go.mod h1:xomTg63KZ2rFqZQzSB4Vz2SUXa1BpHTVz9L5PTmPC4E=
 github.com/MakeNowJust/heredoc v1.0.0 h1:cXCdzVdstXyiTqTvfqk9SDHpKNjxuom+DOlyEeQ4pzQ=
 github.com/MakeNowJust/heredoc v1.0.0/go.mod h1:mG5amYoWBHf8vpLOuehzbGGw0EHxpZZ6lCpQ4fNJ8LE=
-github.com/OpenLiberty/open-liberty-operator v0.8.1-0.20260306042107-9a3cb814041b h1:o5unu1VvLiU5nWBpAM6OQK4pbXWtituF4fQOU54j42M=
-github.com/OpenLiberty/open-liberty-operator v0.8.1-0.20260306042107-9a3cb814041b/go.mod h1:tSb//wAqjTxjaIgyOWvFzgcqK9sMrAmb/S+kKVhM6Pc=
+github.com/OpenLiberty/open-liberty-operator v0.8.1-0.20260318175607-71d13b9b323b h1:JUGDXCIxlOv3W1uok+HtrAP/Cv2u72s4Gg1g3lXBWfo=
+github.com/OpenLiberty/open-liberty-operator v0.8.1-0.20260318175607-71d13b9b323b/go.mod h1:9GqB6Xd1fcN2fg4Rp1pVUfxaUMZwaYJGKy+aHxAlGJE=
 github.com/alecthomas/template v0.0.0-20160405071501-a0175ee3bccc/go.mod h1:LOuyumcjzFXgccqObfd/Ljyb9UuFJ6TxHnclSeseNhc=
 github.com/alecthomas/units v0.0.0-20151022065526-2efee857e7cf/go.mod h1:ybxpYRFXyAe+OPACYpWeL0wqObRcbAqCMya13uyzqw0=
-github.com/application-stacks/runtime-component-operator v1.0.0-20220602-0850.0.20260306040218-27cdcb5746cc h1:fJrVk29GiL/ByZojqoNpx3tM9SkS1lu9PMAv24nunDM=
-github.com/application-stacks/runtime-component-operator v1.0.0-20220602-0850.0.20260306040218-27cdcb5746cc/go.mod h1:rTQgc/5LX8KQLlKezkrMTTyRA8puWTiccXCDxaPa8AM=
+github.com/application-stacks/runtime-component-operator v1.0.0-20220602-0850.0.20260318005646-e267e0c1cb83 h1:3klPsgrcfp52ZV8oIfof+40B6tym9PKAFstQupORB8o=
+github.com/application-stacks/runtime-component-operator v1.0.0-20220602-0850.0.20260318005646-e267e0c1cb83/go.mod h1:rTQgc/5LX8KQLlKezkrMTTyRA8puWTiccXCDxaPa8AM=
 github.com/armon/go-socks5 v0.0.0-20160902184237-e75332964ef5 h1:0CwZNZbxp69SHPdPJAN/hZIm0C4OItdklCFmMRWYpio=
 github.com/armon/go-socks5 v0.0.0-20160902184237-e75332964ef5/go.mod h1:wHh0iHkYZB8zMSxRWpUBQtwG5a7fFgvEO+odwuTv2gs=
 github.com/beorn7/perks v0.0.0-20180321164747-3a771d992973/go.mod h1:Dwedo/Wpr24TaqPxmxbtue+5NUziq4I4S80YR8gNf3Q=

internal/controller/webspherelibertyapplication_controller.go

@@ -1160,15 +1160,8 @@ func (r *ReconcileWebSphereLiberty) getContainerImageMetadata(reqLogger logr.Log
 	wlappSecrets := []corev1.Secret{}
 	var pullSecret *corev1.Secret
 	if wlapp.GetPullSecret() != nil {
-		pullSecretString := strings.TrimSpace(*wlapp.GetPullSecret())
-		pullSecretNames := []string{}
-		if strings.Contains(pullSecretString, ",") {
-			pullSecretNames = strings.Split(pullSecretString, ",")
-		} else {
-			pullSecretNames = append(pullSecretNames, pullSecretString)
-		}
+		pullSecretNames := oputils.DecodeStringToList(*wlapp.GetPullSecret())
 		for _, pullSecretName := range pullSecretNames {
-			pullSecretName = strings.TrimSpace(pullSecretName)
 			pullSecret = &corev1.Secret{}
 			if err := r.GetClient().Get(context.TODO(), types.NamespacedName{Name: pullSecretName, Namespace: wlapp.GetNamespace()}, pullSecret); err != nil {
 				if kerrors.IsNotFound(err) {