preGA WLO 1.6.0 - removing hostAliases from app deployment not getting propagated

[mtamboli]

WLO/OLO has a new feature to create host aliases. After testing this feature, I wanted to remove this stanza to bring application back to original settings. I noticed that the StatefulSet and pods still had those values.
Leo verified that the problem also exists when Deployment is used.

I removed this stanza from app deployment but pods still were have it in /etc/hosts.

  hostAliases:
    - hostnames:
        - qs-db2
      ip: 9.30.249.251

I had to delete the Statefulset for these values to take effect. Updates should be propagated automatically.

[leochr]

Thanks @mtamboli

@kabicin The host alias is not unset in Deployment/SratefulSet. I believe we need to explicitly set it to empty/nil in pod template when .spec.hostAlias is removed from CR. Could you please look into this? Thank you.

[kabicin]

Hi @leochr, I implemented .spec.hostAliases considering the use case in OpenLiberty/open-liberty-operator#211 for users overriding the Deployment manually and preventing breaking changes on their apps once this is released. I can update it to be 1-1 with the CR but we may have to document the limitation for these workarounds.

[leochr]

@kabicin Thank you for the prompt response. Given that this change to officially support host alias is being done in a new channel, it'll be fine. Agree with documenting this change. I'll call it out in the 'What's New' section for this release, so users are aware and use the official config in CR to manage host alias.

[leochr]

Fix for this was included with 1.6.0.

@kabicin Please add test(s) to cover this scenario. Thank you.