Merge pull request #44 from WB-Tooling/default-log-message-writer

feat: refactor constructors in AsyncLogSinkBase and LogSinkBase to use required DefaultLogMessageWriter property

Author: WolfBublitz

src/LogSinks/AsyncLogSinkBase.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Diagnostics.CodeAnalysis;
 using System.Linq;
 using System.Threading;
 using System.Threading.Tasks;
@@ -23,12 +24,11 @@ public abstract class AsyncLogSinkBase<TLogSinkBase> : IAsyncLogSink, IAsyncDisp
     /// <summary>
     /// Initializes a new instance of the <see cref="AsyncLogSinkBase{TLogSinkBase}"/> class with the specified default log message writer.
     /// </summary>
-    /// <param name="defaultLogMessageWriter">The default log message writer to use for payload types that do not have a specific log message writer registered.</param>
-    protected AsyncLogSinkBase(IAsyncLogMessageWriter<object> defaultLogMessageWriter)
+    protected AsyncLogSinkBase()
     {
         logMessageWriterPipeline = new()
         {
-            DefaultLogMessageWriter = defaultLogMessageWriter
+            DefaultLogMessageWriter = DefaultLogMessageWriter
         };
 
         logMessageWriterPipeline.Container.RegisterInstance<IAsyncLogSink>(this);
@@ -38,6 +38,11 @@ protected AsyncLogSinkBase(IAsyncLogMessageWriter<object> defaultLogMessageWrite
     // │ Public Properties                                                           │
     // └─────────────────────────────────────────────────────────────────────────────┘
 
+    /// <summary>
+    /// Gets the default <see cref="IAsyncLogMessageWriter{TPayload}"/> to use for payload types that do not have a specific log message writer registered.
+    /// </summary>
+    public required IAsyncLogMessageWriter<object> DefaultLogMessageWriter { get; init; }
+
     /// <summary>
     /// Gets the <see cref="IContainer"/> associated with this log sink.
     /// </summary>

src/LogSinks/LogSinkBase.cs

@@ -21,12 +21,11 @@ public abstract class LogSinkBase<TLogSinkBase> : ILogSink, IDisposable
     /// <summary>
     /// Initializes a new instance of the <see cref="LogSinkBase{TLogSinkBase}"/> class with the specified default log message writer.
     /// </summary>
-    /// <param name="defaultLogMessageWriter">The default log message writer to use for payload types that do not have a specific log message writer registered.</param>
-    protected LogSinkBase(ILogMessageWriter<object> defaultLogMessageWriter)
+    protected LogSinkBase()
     {
         logMessageWriterPipeline = new()
         {
-            DefaultLogMessageWriter = defaultLogMessageWriter
+            DefaultLogMessageWriter = DefaultLogMessageWriter
         };
 
         logMessageWriterPipeline.Container.RegisterInstance<ILogSink>(this);
@@ -36,6 +35,11 @@ protected LogSinkBase(ILogMessageWriter<object> defaultLogMessageWriter)
     // │ Public Properties                                                           │
     // └─────────────────────────────────────────────────────────────────────────────┘
 
+    /// <summary>
+    /// Gets the default <see cref="ILogMessageWriter{TPayload}"/> to use for payload types that do not have a specific log message writer registered.
+    /// </summary>
+    public required ILogMessageWriter<object> DefaultLogMessageWriter { get; init; }
+
     /// <summary>
     /// Gets the <see cref="IContainer"/> associated with this log sink.
     /// </summary>

tests/AsyncLogSinkBaseTests/src/MethodTests/SubmitAsyncMethodTests.cs

@@ -28,9 +28,6 @@ internal sealed class DefaultLogMessageWriter : IAsyncLogMessageWriter<object>
 {
     public List<ILogMessage> WrittenMessages { get; } = [];
 
-    [NotNull]
-    public TestLogSink? LogSink { get; set; }
-
     public ValueTask WriteAsync(ILogMessage<object> logMessage, CancellationToken cancellationToken)
     {
         WrittenMessages.Add(logMessage);
@@ -51,8 +48,13 @@ public ValueTask WriteAsync(ILogMessage<string> logMessage, CancellationToken ca
     }
 }
 
-internal sealed class TestLogSink() : AsyncLogSinkBase<TestLogSink>(new DefaultLogMessageWriter())
+internal sealed class TestLogSink : AsyncLogSinkBase<TestLogSink>
 {
+    [SetsRequiredMembers]
+    public TestLogSink()
+    {
+        DefaultLogMessageWriter = new DefaultLogMessageWriter();
+    }
 }
 
 public sealed class TheSubmitMethod

tests/LogSinkBaseTests/src/MethodTests/SubmitMethodTests.cs

@@ -41,8 +41,14 @@ public void Write(ILogMessage<string> logMessage)
     }
 }
 
-internal sealed class TestLogSink() : LogSinkBase<TestLogSink>(new DefaultLogMessageWriter())
+internal sealed class TestLogSink : LogSinkBase<TestLogSink>
 {
+
+    [SetsRequiredMembers]
+    public TestLogSink()
+    {
+        DefaultLogMessageWriter = new DefaultLogMessageWriter();
+    }
 }
 
 public sealed class TheSubmitMethod