Skip to content

Commit 90abe56

Browse files
committed
feat: refactor TestLogSink constructors in AsyncLogSinkBase and LogSinkBase to initialize DefaultLogMessageWriter
1 parent 8770f94 commit 90abe56

3 files changed

Lines changed: 14 additions & 5 deletions

File tree

src/LogSinks/AsyncLogSinkBase.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
using System;
2+
using System.Diagnostics.CodeAnalysis;
23
using System.Linq;
34
using System.Threading;
45
using System.Threading.Tasks;

tests/AsyncLogSinkBaseTests/src/MethodTests/SubmitAsyncMethodTests.cs

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,6 @@ internal sealed class DefaultLogMessageWriter : IAsyncLogMessageWriter<object>
2828
{
2929
public List<ILogMessage> WrittenMessages { get; } = [];
3030

31-
[NotNull]
32-
public TestLogSink? LogSink { get; set; }
33-
3431
public ValueTask WriteAsync(ILogMessage<object> logMessage, CancellationToken cancellationToken)
3532
{
3633
WrittenMessages.Add(logMessage);
@@ -51,8 +48,13 @@ public ValueTask WriteAsync(ILogMessage<string> logMessage, CancellationToken ca
5148
}
5249
}
5350

54-
internal sealed class TestLogSink() : AsyncLogSinkBase<TestLogSink>(new DefaultLogMessageWriter())
51+
internal sealed class TestLogSink : AsyncLogSinkBase<TestLogSink>
5552
{
53+
[SetsRequiredMembers]
54+
public TestLogSink()
55+
{
56+
DefaultLogMessageWriter = new DefaultLogMessageWriter();
57+
}
5658
}
5759

5860
public sealed class TheSubmitMethod

tests/LogSinkBaseTests/src/MethodTests/SubmitMethodTests.cs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,14 @@ public void Write(ILogMessage<string> logMessage)
4141
}
4242
}
4343

44-
internal sealed class TestLogSink() : LogSinkBase<TestLogSink>(new DefaultLogMessageWriter())
44+
internal sealed class TestLogSink : LogSinkBase<TestLogSink>
4545
{
46+
47+
[SetsRequiredMembers]
48+
public TestLogSink()
49+
{
50+
DefaultLogMessageWriter = new DefaultLogMessageWriter();
51+
}
4652
}
4753

4854
public sealed class TheSubmitMethod

0 commit comments

Comments
 (0)