Skip to content

Commit 0b4c1cc

Browse files
committed
Replace SOCK_STREAM with SOCK_SEQPACKET (guarantees non-fragmented write), cosmetical
1 parent 43a926e commit 0b4c1cc

1 file changed

Lines changed: 9 additions & 9 deletions

File tree

src/Global.hpp

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ class Signal {
5555

5656
public:
5757

58-
//- disable unwanted signal handlers (SIGINT, SIGPIPE)
58+
// disable unwanted signal handlers (SIGINT, SIGPIPE)
5959
static void disableSignals()
6060
{
6161
signal(SIGINT, SIG_IGN);
@@ -69,15 +69,15 @@ class Syscall {
6969

7070
public:
7171

72-
//- Unix domain socket for FD passing - server side (parent process)
72+
// unix domain socket for FD passing - server side (parent process)
7373
static int createFDPassingServer(const char* socket_path)
7474
{
75-
int server_fd = socket(AF_UNIX, SOCK_STREAM, 0);
75+
int server_fd = socket(AF_UNIX, SOCK_SEQPACKET, 0);
7676
if (server_fd < 0) {
7777
return -1;
7878
}
7979

80-
// Remove any existing socket file
80+
// remove any existing socket file
8181
unlink(socket_path);
8282

8383
struct sockaddr_un server_addr;
@@ -98,10 +98,10 @@ class Syscall {
9898
return server_fd;
9999
}
100100

101-
//- Unix domain socket for FD passing - client side (child process)
101+
// unix domain socket for FD passing - client side (child process)
102102
static int connectFDPassingClient(const char* socket_path)
103103
{
104-
int client_fd = socket(AF_UNIX, SOCK_STREAM, 0);
104+
int client_fd = socket(AF_UNIX, SOCK_SEQPACKET, 0);
105105
if (client_fd < 0) {
106106
return -1;
107107
}
@@ -119,7 +119,7 @@ class Syscall {
119119
return client_fd;
120120
}
121121

122-
//- Send a file descriptor over Unix domain socket
122+
// send a file descriptor over Unix domain socket
123123
static int sendFD(int socket_fd, int fd_to_send)
124124
{
125125
struct msghdr msg;
@@ -152,7 +152,7 @@ class Syscall {
152152
return 0;
153153
}
154154

155-
//- Receive a file descriptor over Unix domain socket
155+
// receive a file descriptor over Unix domain socket
156156
static int recvFD(int socket_fd)
157157
{
158158
struct msghdr msg;
@@ -192,7 +192,7 @@ class Permission {
192192

193193
static void dropPrivileges(uint GroupID, uint UserID)
194194
{
195-
//- in case of being root, drop privileges
195+
// in case of being root, drop privileges
196196
if (getuid() == 0) {
197197

198198
if (setgid(GroupID) != 0) {

0 commit comments

Comments
 (0)