TypeError when using upload_workflow: unsupported operand type(s) for /: 'str' and 'int'

[garybrowne]

Hello,

I'm passing a list of Paths to the "files" argument to the api.upload_workflow method. However, I think that the file_info object generated internally sets the file_info["size"] value as a str, not an int.

Error trace:

ERROR:xxx.clients.filesender_client:Upload failed: unsupported operand type(s) for /: 'str' and 'int'

Traceback (most recent call last):
  File "/xxx/clients/filesender_client.py", line 78, in upload_file
    transfer = await self.client.upload_workflow(
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

  File "/xxx/.venv/lib/python3.12/site-packages/filesender/api.py", line 486, in upload_workflow
    await stream.starmap(_upload_args(), self.upload_complete, ordered=False, task_limit=self.concurrent_files) # type: ignore
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
.
.
.
  File "/xxx/.venv/lib/python3.12/site-packages/filesender/api.py", line 325, in upload_file
    async for _ in tqdm(streamer, total=math.ceil(file_info["size"] / self.chunk_size), desc=file_info["name"]): # type: ignore
                                                  ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
TypeError: unsupported operand type(s) for /: 'str' and 'int'
ERROR:__main__:Upload failed: unsupported operand type(s) for /: 'str' and 'int'
Traceback (most recent call last):
  File "/xxx/test_xnat_to_filesender.py", line 194, in upload_local_to_filesender
    transfer_id = await filesender_client.upload_file(
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/xxx/clients/filesender_client.py", line 78, in upload_file
    transfer = await self.client.upload_workflow(
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/xxx/.venv/lib/python3.12/site-packages/filesender/api.py", line 486, in upload_workflow
    await stream.starmap(_upload_args(), self.upload_complete, ordered=False, task_limit=self.concurrent_files) # type: ignore
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
.
.
.
  File "/xxx/.venv/lib/python3.12/site-packages/filesender/api.py", line 325, in upload_file
    async for _ in tqdm(streamer, total=math.ceil(file_info["size"] / self.chunk_size), desc=file_info["name"]): # type: ignore
                                                  ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
TypeError: unsupported operand type(s) for /: 'str' and 'int'
ERROR:__main__:FAILED uploading local files: unsupported operand type(s) for /: 'str' and 'int'

Would you have any time to investigate this, or would you be open to a PR to rectify (if it is indeed a bug)?

Thanks very much

[multimeric]

Thanks for the report. I'm open to a PR, but first I need to understand the issue. I'm sure that that field is not a string on the FileSender server that I use. Can you share with me the version info? You can get this using filesender --base-url XXX server-info

[garybrowne]

Thanks for the quick response! From the server-info command I only get back 'url', 'name', 'logon_url', 'upload_chunk_size' and 'forward_capabilities'. Is there a flag I'm missing?

[garybrowne]

I'm using the latest version of this codebase (2.1.1) at the time of writing. If I add some debug statements locally, I get this:

INFO:filesender.api:typeof file_info["size"] is <class 'str'>
INFO:filesender.api:typeof self.chunk_size is <class 'int'>

I can get around this with something like:

file_size = int(file_info["size"])
async for _ in tqdm(streamer, total=math.ceil(file_size / self.chunk_size), desc=file_info["name"]): # type: ignore

Unfortunately that leads to another error:

filesender/api.py", line 344, in _upload_chunk
    params={"key": file_info["uid"]},
                   ~~~~~~~~~^^^^^^^
KeyError: 'uid'
ERROR:__main__:Upload failed: 'uid'

[rdenham]

Just confirming that I also experience this issue. This is on AARNet FileSender (filesender.aarnet.edu.au), where it seems file["size"] in the transfer response is returned as a string rather than an integer.

With the uid error, it seems that our api server uses puid not uid. So it would be good if we could handle both cases.

[rdenham]

I've made a pull request for this #40 Note this would also cover #39, but still be backwards compatible.