Integrate test Project.toml into main Project.toml#30
Conversation
b5bb1b7 to
a35c6be
Compare
|
@chmerdon Seems fine now. I think the module is more maintainable if we have only a single |
|
... It is a matter of taste IMHO. I didn't find a reference stating what is preferred by the julia developers. I personally kind of prefer to have test/Project.toml . Anyway we also have docs/Project.toml. |
|
When I was new to Julia I was always confused by the splitting into test/main
|
|
is docs really that independent? it runs the same examples, uses all the docstrings... I also find it weird to have then still the docs/Project.toml separately. Can one handle the docs similarly with another target docs? |
|
Technically, As far as I know, the only valid And I think 2 |
And bump patch version
|
Rebased to current master. Will merge if CI passes. |
|
see this discussion on discourse: https://discourse.julialang.org/t/about-checking-a-package-library-manifest-toml-into-control-version-again/127490/8 |
|
From the discussion I take home that the current creation of the test environment is a mess if a separate We seem to have some weird compat problems along the WIAS-PDELib. Let us keep things as simple as possible to track down these problems. PS: Right now the CI fails since before the test environment was different than it is now. This pretty much underlines my argument. |
|
... the currently failing test doesn't seem to fail due to CI configuration, but seems to assume that mesh generation always results in the same grid size, however due to floating point arithmetic this is true only approximately. |
|
In VoronoiFVM you can look up how to test on Apple Silicon, I would add this here. |
|
Yes, you are right. The CI fail occurred before on the master branch after merging the latest PRs. You think this is caused by floating point arithmetic problems? Why did the test work before? |
This fails due to some rounding errors. See #44
Let's see if it runs through