-
Notifications
You must be signed in to change notification settings - Fork 12
some doc improvements, version bump to 1.4 #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
69f1fc0
some doc improvements, version bump to 1.4
chmerdon d735c0c
printout in Example201 when module is loaded
904a52a
fixed id <> idt
chmerdon 1471a47
removed info-on-include message for Example201.. maybe later
chmerdon 0ecfaad
Merge branch 'master' into chmerdon/doc_fixes
chmerdon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -159,23 +159,30 @@ function BilinearOperatorDG( | |
| Generates a bilinear form that evaluates the vector product of the (discontinuous) | ||
| operator evaluation(s) of the test function(s) with the (discontinuous) operator evaluation(s) | ||
| of the ansatz function(s). If a function is provided in the first argument, | ||
| the ansatz function evaluations can be customized by the kernel function | ||
| the ansatz function evaluations can be customized by the kernel function, | ||
| and its result vector is then used in a dot product with the test function evaluations. | ||
| In this case the header of the kernel functions needs to be conform | ||
| to the interface | ||
| In this case, the header of the kernel function must conform to the interface: | ||
|
|
||
| kernel!(result, eval_ansatz, qpinfo) | ||
| kernel!(result, eval_ansatz, qpinfo) | ||
|
|
||
| where qpinfo allows to access information at the current quadrature point. | ||
| where `qpinfo` allows access to information at the current quadrature point. | ||
|
|
||
| Operator evaluations are tuples that pair an unknown identifier or integer | ||
| with a Function operator. | ||
| with a function operator (such as those generated by `jump(grad(u))`, `id(u)`, etc). | ||
|
|
||
| Example: BilinearOperatorDG([jump(grad(1))], [jump(grad(1))]; kwargs...) generates an interior penalty stabilisation. | ||
| # Arguments | ||
| - `oa_test`: Array of tuples `(unknown, operator)` for test functions. | ||
| - `oa_ansatz`: Array of tuples `(unknown, operator)` for ansatz (trial) functions. Defaults to `oa_test`. | ||
| - `kwargs...`: Additional keyword arguments for operator assembly (see below). | ||
|
|
||
| Keyword arguments: | ||
| # Keyword arguments | ||
| $(_myprint(default_blfopdg_kwargs())) | ||
|
|
||
| # Example | ||
| ```julia | ||
| BilinearOperatorDG([jump(grad(1))], [jump(grad(1))]; entities=ON_FACES) | ||
| ``` | ||
|
|
||
| """ | ||
| function BilinearOperatorDG(oa_test::Array{<:Tuple{Union{Unknown, Int}, DataType}, 1}, oa_ansatz::Array{<:Tuple{Union{Unknown, Int}, DataType}, 1} = oa_test; kwargs...) | ||
| u_test = [oa[1] for oa in oa_test] | ||
|
|
@@ -375,7 +382,7 @@ function build_assembler!(A, O::BilinearOperatorDG{Tv}, FE_test, FE_ansatz, FE_a | |
| couple = false | ||
| for j in 1:op_lengths_ansatz[id] | ||
| for k in 1:op_lengths_test[idt] | ||
| if sparsity_pattern[k + op_offsets_test[idt], j + op_offsets_ansatz[id]] > 0 | ||
| if sparsity_pattern[k + op_offsets_test[id], j + op_offsets_ansatz[idt]] > 0 | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this change intended? It is not explained anywhere. |
||
| couple = true | ||
| end | ||
| end | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
solves