Skip to content

Two bugfixes for ItemIntegratorDG #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chmerdon merged 2 commits into from
Dec 5, 2025
Merged

Two bugfixes for ItemIntegratorDG #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23b6dd1
ItemIntegratorDG now recognizes regions, sizing for boundary entities…
Dec 5, 2025
f5e3731
added changelog entry
Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

### Fixed
- fixed type issues in LinearOperator and ItemIntegrator
- fixed region awareness and output array sizing for boundary entities in ItemIntegratorDG

## v1.7.0

Expand Down
10 changes: 8 additions & 2 deletions src/common_operators/item_integrator_dg.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,12 @@ function build_assembler!(O::ItemIntegratorDG{Tv}, FE_args::Array{<:FEVectorBloc
end
end

if itemregions[item] > 0
if !(visit_region[itemregions[item]])
continue
end
end

for qp in 1:nweights
## evaluate arguments at quadrature points
fill!(input_args, 0)
Expand Down Expand Up @@ -364,9 +370,9 @@ function evaluate(O::ItemIntegratorDG{Tv, UT}, sol; kwargs...) where {Tv, UT}
elseif AT <: ON_EDGES
nitems = size(grid[EdgeNodes], 2)
elseif AT <: ON_BFACES
nitems = size(grid[BFaceNodes], 2)
nitems = size(grid[FaceNodes], 2)
elseif AT <: ON_BEDGES
nitems = size(grid[BEdgeNodes], 2)
nitems = size(grid[EdgeNodes], 2)
end
if O.parameters[:piecewise]
b = zeros(eltype(sol[1].entries), O.parameters[:resultdim], nitems)
Expand Down
Loading