Skip to content

Streamline plots trigger + new Example295 on a sliding droplet + improvements in other examples#95

Merged
chmerdon merged 10 commits intomasterfrom
chmerdon/sliding_droplet_example
Dec 18, 2025
Merged

Streamline plots trigger + new Example295 on a sliding droplet + improvements in other examples#95
chmerdon merged 10 commits intomasterfrom
chmerdon/sliding_droplet_example

Conversation

@chmerdon
Copy link
Copy Markdown
Member

@chmerdon chmerdon commented Dec 10, 2025

  • new Example295 on a sliding droplet
  • streamlines(u) in plot triggers streamplot
  • modified test in Example211 to fix issue Fix test in Example211 #44

@chmerdon chmerdon changed the title new Example295 on a sliding droplet new Example295 on a sliding droplet + improvements in other examples Dec 12, 2025
@chmerdon chmerdon changed the title new Example295 on a sliding droplet + improvements in other examples Streamline plots trigger + new Example295 on a sliding droplet + improvements in other examples Dec 18, 2025
Copy link
Copy Markdown
Member

@pjaap pjaap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some small nitpicks.

But thanks for adding streamplot to the code.

## evaluate eqilibration error estimator and append it to sol vector (for plotting etc.)
local_equilibration_estimator!(sol, FETypeDual)
η4cell = evaluate(EQIntegrator, sol)
@info η4cell
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this stay in the code?

@test length(sol.entries) == 8641 #hide
results, plt = main(; maxdofs = 21, order = 2) #hide
@test length(results[1].entries) == 96 #hide
@test all(results[2] .≈ [0.0005948849237161765 0.02155094069716629 0.0012248396092485094 0.01840063545660059 0.02155094068517524 0.0005948849232996949])
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same as @test results[2] ≈ [0.0005948849237161765 0.02155094069716629 0.0012248396092485094 0.01840063545660059 0.02155094068517524 0.0005948849232996949] but more complicated?

Comment thread src/unknowns.jl Outdated
"""
streamlines(u)

alias for (u, "grid") (triggers streamlines plot)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alias for (u, "streamlines") !

Comment thread CHANGELOG.md Outdated
## v1.8.0

### Added
- new keyword streamlines that can be used in the plotfunction to trigger GridVisualize.streamplot, now used in Example252
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keyword is misleading. This is an operator?

@pjaap
Copy link
Copy Markdown
Member

pjaap commented Dec 18, 2025

thanks for the edits. Looks good now

@chmerdon chmerdon merged commit 34c5b17 into master Dec 18, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants