Conversation
…es, NodeEdges - dcostrings for all derived types
|
Nice. Can you add a Changelog entry and bump the minor version number? I think we can ignore the nightly failure. |
|
ok, another question: in FaceNodes instantiation also atranspose(xgrid[CellNodes]) is needed, should this be switched to grid[NodeCells] as well (triggering that this is saved always in the grid as soon as FaceNodes are involved)? |
|
Yes, sounds always reasonable to keep the result |
Usually this step is a very fast and non-time-critical step in the other global adjacency instantiations where this is used. So not saving the same numbers twice might be also a reasonable default behavior. |
|
True. I tend to keeps thing as they are if we are not sure. Maybe add a comment at the specific code line? |
…, lines with atranpose have a comment indicating that one might use the new storage-inducing adjacency types
|
When adding this branch I get the warning |
ef9b472 to
db5d9bc
Compare
j-fu
left a comment
There was a problem hiding this comment.
Looks good to me.
We should notice the issue of "garbage collection" of grid items.
In the moment I have no idea how to proceed with this.
|
I opened issue #90 on garbage collection and will merge this PR now. |
Uh oh!
There was an error while loading. Please reload this page.