Add colorbar for cell regions in 2D gridplot! with Py[thon]Plot#123
Merged
Add colorbar for cell regions in 2D gridplot! with Py[thon]Plot#123
gridplot! with Py[thon]Plot#123Conversation
pjaap
reviewed
Apr 21, 2026
| bcdata; | ||
| ax = ax, | ||
| ticks = collect(1:length(bcmap)), | ||
| orientation = "horizontal", |
Member
There was a problem hiding this comment.
Nice!
Nitpicking: sine we have a lot of duplicated code here:
Can you add something like if ctx[:colorbar] in [:vertical, :horizontal]
and then orientation = "$(ctx[:colorbar])"?
This should be more compact
| @@ -1,5 +1,8 @@ | |||
| # Changelog | |||
|
|
|||
| ## [1.18.1] - 2026-04-21 | |||
Member
There was a problem hiding this comment.
If you add a CHANGELOG entry, then you have to bump the version too.
Collaborator
Author
|
For the sake of completeness, here is my example of a 2D grid plot with complete color bars: 
|
pjaap
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that, in addition to the colorbar for boundary regions, a colorbar for cell regions was missing for 2D gridplots when using the PyPlot/ PythonPlot backend. This PR adds the missing colorbar within the
gridplot!function.